Skip to content

Commit e3bd971

Browse files
sgnycknitt
authored andcommitted
change event type from string to variant for Dimensions.addEventListener (#411)
1 parent 0c8ff63 commit e3bd971

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

‎bs-react-native-next/src/apis/Dimensions.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@ type handler = {
2222
[@bs.module "react-native"] [@bs.scope "Dimensions"]
2323
external get: ([@bs.string] [ | `window | `screen]) => t = "";
2424
[@bs.module "react-native"] [@bs.scope "Dimensions"]
25-
external addEventListener: (string, handler => unit) => unit = "";
25+
external addEventListener: ([@bs.string] [ | `change], handler => unit) => unit =
26+
"";
2627
[@bs.module "react-native"] [@bs.scope "Dimensions"]
27-
external removeEventListener: (string, handler => unit) => unit = "";
28+
external removeEventListener:
29+
([@bs.string] [ | `change], handler => unit) => unit =
30+
"";
2831
2932
```

‎bs-react-native-next/src/apis/Dimensions.re‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ type handler = {
1515
[@bs.module "react-native"] [@bs.scope "Dimensions"]
1616
external get: ([@bs.string] [ | `window | `screen]) => t = "";
1717
[@bs.module "react-native"] [@bs.scope "Dimensions"]
18-
external addEventListener: (string, handler => unit) => unit = "";
18+
external addEventListener: ([@bs.string] [ | `change], handler => unit) => unit =
19+
"";
1920
[@bs.module "react-native"] [@bs.scope "Dimensions"]
20-
external removeEventListener: (string, handler => unit) => unit = "";
21+
external removeEventListener:
22+
([@bs.string] [ | `change], handler => unit) => unit =
23+
"";

0 commit comments

Comments
 (0)