Repository navigation
Add support for JSX file format as well via create-email #423
Description
Using this command, i am able to create starter email
npx create-email@latestBy default, above command create Component files in .tsx file format, it would be great if there is flag to enable the support for .jsx file format as well
Suggestion:
npx create-email@latest --jsxNote: JSX file support is already in place via [#231]. Asking for flag to enable the creation of Components as jsx file.
Activity
bukinoshita commentedon Feb 1, 2023
Nice, thanks for creating this @gokulkrishh.
I think we can have a
typescriptflag.gokulkrishh commentedon Feb 1, 2023
@bukinoshita So by default
.JSXand a flag fortypescript. This would great.bastiaanv commentedon Feb 2, 2023
I would suggest to switch it around. Typescript by default, and
.JSXas flag. Typescript is currently the default for most frameworksgokulkrishh commentedon Feb 2, 2023
@bastiaanv I am not so sure about typescript being the default for most frameworks (Not trying to start a debate on typescript 😄).
For CRA and NextJS, we need to pass
--typescriptflag. Realised this after check the docs.Would leave this decision to you people to decide.
bukinoshita commentedon Feb 6, 2023
Yeah, I'd prefer having Typescript as default as well, but most libraries has JS as default instead of typescript. So I'd suggest going with
jsxas default and in the example always show thetypescriptflag.