Skip to content

fix: padding in Container/Section failing on Klavyio and Outlook - #2257

Merged
dielduarte merged 6 commits into
resend:canaryfrom
bernaferrari:bernardo
May 22, 2026
Merged

dielduarte merged 6 commits into
resend:canaryfrom
bernaferrari:bernardo

Conversation

@bernaferrari

@bernaferrari bernaferrari commented May 20, 2025 •

Copy link
Copy Markdown
Contributor

Closes #2256

@changeset-bot

changeset-bot Bot commented May 20, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8d3f673

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-email Patch
@react-email/editor Patch
@react-email/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

@bernaferrari is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@bernaferrari bernaferrari changed the title fix(react-email) Improve compatibility with Klavyio and Outlook fix(react-email) Fix padding + table failing on Klavyio and Outlook May 20, 2025
@pkg-pr-new

pkg-pr-new Bot commented May 20, 2025 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@2257
npm i https://pkg.pr.new/react-email@2257
npm i https://pkg.pr.new/@react-email/ui@2257

commit: 8d3f673

@gabrielmfern
gabrielmfern force-pushed the canary branch 3 times, most recently from 61d045a to cee3eec Compare June 4, 2025 14:01
@gabrielmfern
gabrielmfern force-pushed the canary branch 4 times, most recently from addf436 to ade5f69 Compare June 16, 2025 14:07
@gabrielmfern
gabrielmfern force-pushed the canary branch 4 times, most recently from 3ff8597 to 3c4ea0a Compare June 30, 2025 13:13
@gabrielmfern gabrielmfern changed the title fix(react-email) Fix padding + table failing on Klavyio and Outlook fix(react-email) padding in Container failing on Klavyio and Outlook Jul 4, 2025
@gabrielmfern
gabrielmfern requested a review from a team as a code owner September 12, 2025 12:53
@gabrielmfern
gabrielmfern requested review from gabrielmfern and removed request for a team September 12, 2025 12:53
@gabrielmfern
gabrielmfern force-pushed the canary branch 4 times, most recently from 7da803f to e9af285 Compare October 24, 2025 12:33
@gabrielmfern

Copy link
Copy Markdown
Member

Going to close this due to inactivity, and since it was also working in Outlook, the email client we promise support for.

@bernaferrari

Copy link
Copy Markdown
Contributor Author

it is only inactivity because no one reviewed

@gabrielmfern gabrielmfern reopened this Mar 18, 2026
Comment thread packages/container/src/container.tsx Outdated
@gabrielmfern

gabrielmfern commented Mar 18, 2026 •

Copy link
Copy Markdown
Member

it is only inactivity because no one reviewed

you're right, I forgot to actually send the comment that I wrote a while back. feel free to continue with it, sorry

@gabrielmfern gabrielmfern changed the title fix(react-email) padding in Container failing on Klavyio and Outlook fix: padding in Container/Section failing on Klavyio and Outlook Mar 18, 2026
@gabrielmfern

Copy link
Copy Markdown
Member

can you also update the test snapshots? pnpm test --update in packages/container and packages/section should be enough

@bernaferrari

Copy link
Copy Markdown
Contributor Author

It should work now.

@github-actions github-actions Bot added the linear-synced PR has been synced to Linear label May 14, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: This PR moves padding styles from the outer table to an inner td element in Container and Section components to improve compatibility with Klavyio and Outlook, a straightforward and low-risk change that only affects email rendering with a simple loop splitting style properties.

Re-trigger cubic

@vercel

vercel Bot commented May 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 21, 2026 8:06pm
react-email-demo Ready Ready Preview, Comment May 21, 2026 8:06pm

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Auto-approved: This PR moves padding styles from the outer table element to the inner td element in Container and Section components to improve email client compatibility, with corresponding snapshot and test updates, and the change is isolated, low-risk, and addresses a known rendering issue.

Re-trigger cubic

@dielduarte

Copy link
Copy Markdown
Contributor

Hey @bernaferrari thank you for the contribution! we are merging this one now.

@dielduarte
dielduarte merged commit c610dc0 into resend:canary May 22, 2026
13 of 14 checks passed

This branch was successfully deployed

2 active deployments
Preview – react-email-demo — 8d3f673a Deployed May 21, 2026 by vercel[bot]
Preview – react-email — 8d3f673a Deployed May 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear-synced PR has been synced to Linear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

padding doesn't work in table for Klavyio

3 participants