Repository navigation
feat(editor): run CSS processing via tsdown onSuccess hook - #3121
Merged
gabrielmfern merged 4 commits intoMar 26, 2026
Merged
Conversation
Moves CSS processing from a separate build:css step into tsdown's onSuccess hook so it runs automatically after every successful build, including during build:watch. Previously, build:watch only ran tsdown without the CSS processing step, meaning CSS changes were not picked up. Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
cursor
Bot
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
gabrielmfern
marked this pull request as ready for review
March 26, 2026 14:01
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
joaopcm
approved these changes
Mar 26, 2026
gabrielmfern
added a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves CSS processing into tsdown's
onSuccesshook so that it runs automatically after every successful build, including duringbuild:watch.Problem
Previously, the editor package's CSS processing (
scripts/copy-css.ts) was only run as a separate step aftertsdownin thebuildscript:The
build:watchscript only rantsdown --watchwithout any CSS processing, meaning CSS changes were never picked up during watch mode.Solution
Added
onSuccess: 'tsx scripts/copy-css.ts'totsdown.config.ts. This tells tsdown to execute the CSS processing script after every successful build — both in regularbuildandbuild:watchmodes.The
buildscript was simplified fromtsdown && pnpm run build:cssto justtsdown, since CSS processing is now handled by tsdown's lifecycle. The standalonebuild:cssscript is retained for manual use.Changes
packages/editor/tsdown.config.ts: AddedonSuccessoption to run CSS copy/processing after each buildpackages/editor/package.json: Simplifiedbuildscript to justtsdownSlack Thread
Summary by cubic
Run editor CSS processing via
tsdown’sonSuccesshook so styles update after every build, includingbuild:watch. Usespnpm build:cssand simplifies thebuildscript.onSuccess: 'pnpm build:css'inpackages/editor/tsdown.config.ts.buildtotsdowninpackages/editor/package.json; keepbuild:cssfor manual runs.Written for commit c08ac64. Summary will update on new commits.