Repository navigation
fix(create-email): validate npm registry response and exit on invalid version - #3741
Merged
felipefreitag merged 2 commits intoSep 22, 2026
Conversation
… version Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
Contributor
|
@Tyagiquamar is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: e05fc73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The npm registry answers a missing tag with HTTP 404, so the generic ok check hid the specific "Tag X does not exist" message. Check for 404 first, then for any other non-OK status, then parse the body.
felipefreitag
approved these changes
Sep 22, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check response.ok when querying npm registry in getLatestVersionOfTag inside create-email. Immediately exit with error status if the npm HTTP request fails, tag is not found, or the version format is invalid/empty, preventing create-email from silently writing undefined versions into starter package.json.
Summary by cubic
Fixes
create-emailto validate the npm registry response and exit with an error when the request fails or the version is empty/invalid, instead of silently writingundefinedinto the starterpackage.json. Missing tags (HTTP 404) keep their specific error message before the generic failure check.Written for commit e05fc73. Summary will update on new commits.