Skip to content

chore(deps): remove normalize-path dependency - #3782

Open
LuggaPugga wants to merge 1 commit into
resend:canaryfrom
LuggaPugga:chore/remove-normalize-path
Open

LuggaPugga wants to merge 1 commit into
resend:canaryfrom
LuggaPugga:chore/remove-normalize-path

Conversation

@LuggaPugga

@LuggaPugga LuggaPugga commented Oct 9, 2026 •

Copy link
Copy Markdown

Remove normalize-path dependency

The output directory is now passed to glob through the cwd option instead of being part of the pattern, so no path normalization is needed:

const allBuiltTemplates = glob.sync('**/*.cjs', {
  cwd: pathToWhereEmailMarkupShouldBeDumped,
  absolute: true,
});

This also removes the unused @types/normalize-path from packages/ui.

Behavior

Nothing changes for ordinary output directories. One side effect is a fix: an --outDir containing glob characters was previously treated as part of the pattern.

--outDir Before After
out[1], out{a,b} No templates found, nothing rendered Templates render
out* Also picked up .cjs files from sibling directories Only that directory is searched

Summary by cubic

Removes the normalize-path dependency by passing --outDir to glob's cwd option instead of concatenating it into the pattern.

Fixes two edge cases: --outDir values containing glob characters (like out[1] or out{a,b}) previously matched no templates, and values like out* previously pulled in .cjs files from sibling directories. Both now correctly search only the intended output directory. Also removes the unused @types/normalize-path from packages/ui.

Written for commit 6e6bd23. Summary will update on new commits.

View guided diff

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

鈿狅笍 No Changeset found

Latest commit: 6e6bd23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@LuggaPugga is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the linear-synced PR has been synced to Linear label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear-synced PR has been synced to Linear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant