Merge pull request #15 from rhythmictech/FEC-3922

FEC-3922 - Suppress stack trace in Tomcat error responses

Author: dgoodellrhy

defaults/main.yml

@@ -37,6 +37,8 @@ tomcat_umask: '0022'
 tomcat_add_user_to_group: false
 tomcat_unit_file_overrides: []
 
+tomcat_suppress_error_reports: true
+
 # This will be randomly generated every ansible run if not set
 tomcat_shutdown_value: 'SETME'
 

meta/main.yml

@@ -1,6 +1,8 @@
 ---
 
 galaxy_info:
+  role_name: tomcat
+  namespace: rhythmictech
   author: Rhythmic Open Source <opensource@rhythmictech.com>
   description: Ansible Role for Apache Tomcat
   company: Rhythmic Technologies, Inc.

molecule/default/converge.yml

@@ -7,4 +7,4 @@
   tasks:
     - name: "Include ansible-role-tomcat"
       include_role:
-        name: "ansible-role-tomcat"
+        name: "rhythmictech.tomcat"

molecule/default/molecule.yml

@@ -5,14 +5,16 @@ driver:
   name: docker
 platforms:
   - name: instance
-    image: docker.io/pycontribs/centos:7
+    image: docker.io/geerlingguy/docker-amazonlinux2023-ansible
     pre_build_image: true
-    command: /sbin/init
+    command: /usr/lib/systemd/systemd
     tmpfs:
       - /run
       - /tmp
     volumes:
-      - /sys/fs/cgroup:/sys/fs/cgroup:ro
+      - /sys/fs/cgroup:/sys/fs/cgroup:rw
+    cgroupns_mode: host
+    privileged: true
 provisioner:
   name: ansible
 verifier:

molecule/default/prepare.yml

@@ -0,0 +1,8 @@
+---
+- name: Prepare
+  hosts: all
+  tasks:
+    - name: ensure tar is installed
+      ansible.builtin.package:
+        name: tar
+        state: present

tasks/main.yml

@@ -35,6 +35,7 @@
 - name: give tomcat group access to read all in CATALINA_HOME
   command: "find {{ _tomcat_catalina_home }}/ -exec /bin/chgrp {{ tomcat_group }} {} \\;"
   tags: ['tomcat']
+  changed_when: false
 
 - name: restrict access to CATALINA_HOME
   file: path="{{ _tomcat_catalina_home }}" state=directory owner="root" group="{{ tomcat_group }}" mode='0750'

templates/catalina_base.conf.server.xml.j2

@@ -47,6 +47,10 @@
 {% endif %}
 {% if tomcat_rewrite_rules|length > 0 %}
         <Valve className="org.apache.catalina.valves.rewrite.RewriteValve" />
+{% endif %}
+{% if tomcat_suppress_error_reports %}
+        <Valve className="org.apache.catalina.valves.ErrorReportValve"
+               showReport="false" showServerInfo="false" />
 {% endif %}
         <Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs"
                prefix="localhost_access_log" suffix=".txt"