Skip to content

Add all attributes for nodes and edges - #399

Open
randrescastaneda wants to merge 8 commits into
rich-iannone:mainfrom
randrescastaneda:add_attrs
Open

Add all attributes for nodes and edges#399
randrescastaneda wants to merge 8 commits into
rich-iannone:mainfrom
randrescastaneda:add_attrs

Conversation

@randrescastaneda

Copy link
Copy Markdown

Dear @rich-iannone ,

I just added all the available attributes for nodes and edges of this page . Right now it is not possible to add edge attributes like arrowhead or minlen . However, with this small addition it is possible.

thanks.

@rich-iannone

Copy link
Copy Markdown
Owner

@randrescastaneda Thanks for the PR! Would you be able to fix the failing tests? Also node_aes() (https://github.com/rich-iannone/DiagrammeR/blob/master/R/node_aes.R) and edge_aes()(https://github.com/rich-iannone/DiagrammeR/blob/master/R/edge_aes.R) both need to be revised to accommodate the new parameters. Also, this vignette needs to be updated: https://github.com/rich-iannone/DiagrammeR/blob/master/vignettes/node-edge-data-frames.Rmd.

@randrescastaneda

Copy link
Copy Markdown
Author

Absolutely. It would be a pleasure.
I'll notify you when it is ready.
Best,

@jrgant

jrgant commented Aug 5, 2026

Copy link
Copy Markdown

Are there any plans to merge this in? It would be helpful to have access to all the node and edge attributes provided by graphviz. I can take a crack at any fixes/outstanding issues with the PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants