Fix dotvvm lint: master pages, --project option, file filtering, metadata caching - #2095
Merged
Conversation
Closed
…filtering, build cache Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
…e error message Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DotVVM CLI lint issues for master pages and performance
Fix dotvvm lint: master pages, --project option, file filtering, metadata caching
Aug 20, 2026
tomasherceg
reviewed
Aug 21, 2026
…not filesystem scan Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
tomasherceg
reviewed
Aug 21, 2026
Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
exyi
approved these changes
Aug 21, 2026
exyi
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues with
dotvvm lint: master pages were silently skipped, the project path was a positional arg (not AI-friendly), and every run triggered a slow MSBuild metadata rebuild.Master pages now linted
StaticViewCompiler.CompileAllscans the project directory for.dotmasterfiles and compiles them alongside registered markup controls and route views. A set tracks already-compiled paths to avoid duplicates.--projectoption + per-file argumentThe lint command now accepts
--project(option, defaults to CWD) instead of the old positionaltargetargument. A new optional positional argument accepts one or more specific.dothtml/.dotcontrol/.dotmasterpaths — only diagnostics for those files are reported:Other commands retain the existing
targetpositional argument unchanged.Metadata caching (
dotvvm-cli.json)DotvvmProject.FromCsprojnow skips the MSBuild_WriteDotvvmProjectMetadatainvocation whenobj/dotvvm-cli.jsonis newer than the.csproj. A--force-buildflag forces regeneration when needed.Compiler-side file filtering
DotVVM.Compilergained a--filesoption (passed after the two positional args) that filters diagnostic output to the specified virtual paths. The CLI converts user-supplied absolute paths to project-relative virtual paths before forwarding them.lintissues #2093