Fix null handling when calling custom JsonConverters - #2103
Merged
Conversation
System.Text.Json converters have HandleNull property, which we should respect: * when false (default), both serialization and deserialization should handle null values before the converter is called. Conterintuitively this is the case even if converter is explicitely defined for Nullable<...> type * when true: we don't check for null and let converter handle it We always allow null in DotvvmConverters, because they all already handle it, and it keeps the generated code smaller.
exyi
force-pushed
the
serializer-fix-converter-HandleNull
branch
from
August 28, 2026 11:56
5aa6a32 to
4468757
Compare
tomasherceg
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Text.Json converters have HandleNull property, which we should respect:
We always allow null in DotvvmConverters, because they all already handle it, and it keeps the generated code smaller.