Refactored core folder - #298
Conversation
|
Can you check all relative address mapping are correct or not, I can see some problems. |
|
Well that's expected,it's a work in progress I just wanted to make sure the implementation is as intended.Can you confirm the same? |
|
Yes, this is the intent of the reorganization issue. Appreciate your effort on this. We did talk about this PR during our last meeting and decided to get the other PRs merged before focusing on this one. Apologies for not commenting earlier. |
|
haha no worries,just let me know any updates on this.Also I dont use ubuntu so I cant verify the regress failing.Its working fine on my arch based os and regress is passing. |
|
Im sorry I didnt check thoroughly for linking errors,I fixed it now kindly review and rerun the tests |
|
@klingaard, I have gone through the entire PR and it looks good from the edm integration point. I aim to have the EDMInstanceGenerator inside the |
|
Ok, thanks for looking it over. Let's discuss this PR in the next SIG meeting. If folks feel ok with it (it's quite a transition), then we'll merge it in. |
|
I'd like to merge this in after the current PRs we have are in. |
Refactor(Core): Decompose Core into Per-Unit Static Libraries addresses #3
This PR addresses the request to refactor the core directory.Each logical unit within core has been organized into its own directory and is now built as a separate static library.
Summary of Changes:
Structural Reorganization:
sim_engine.
Build System Refactoring (CMake):
libcore_cpu.a, libcore_inst.a).
libraries (core_cpu, core_inst, fetch, decode, etc.).
Dependency Resolution:
using target_link_libraries. This ensures correct include path propagation and resolves all build errors.
Current Status:
Feedback Needed:
Is this the intended result?
Also what did you mean by unit testing for each unit?