Skip to content

add zvabd draft spec - #381

Merged
Andrew Waterman (aswaterman) merged 4 commits into
riscv:masterfrom
keyon1992:zvabd
Dec 2, 2025
Merged

add zvabd draft spec#381
Andrew Waterman (aswaterman) merged 4 commits into
riscv:masterfrom
keyon1992:zvabd

Conversation

@keyon1992

Copy link
Copy Markdown
Contributor

@keyon1992

Copy link
Copy Markdown
Contributor Author

Andrew Waterman (@aswaterman) hi, could you please help to review this PR

@keyon1992

Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing newline at the end of the file.

@keyon1992

Copy link
Copy Markdown
Contributor Author

Please add the missing newline at the end of the file.

done

@aswaterman

Copy link
Copy Markdown
Member

Qian Jiayan (@keyon1992) thank you!

Qian Jiayan (@keyon1992) / Ved Shanbhogue (@ved-rivos) do either of you recall if the ARC assigned these particular opcodes? They seem reasonable at a glance.

@codecov

codecov Bot commented Dec 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (383cbca) to head (a82447a).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   96.53%   97.08%   +0.55%     
==========================================
  Files          10       14       +4     
  Lines         750      926     +176     
==========================================
+ Hits          724      899     +175     
- Misses         26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keyon1992

Qian Jiayan (keyon1992) commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

Qian Jiayan (@keyon1992) thank you!

Qian Jiayan (@keyon1992) / Ved Shanbhogue (@ved-rivos) do either of you recall if the ARC assigned these particular opcodes? They seem reasonable at a glance.

I think there are no vector fast tracks besides Sifve dot-products, so Zvabd/Zvzip opcodes should be reasonable.

@keyon1992

Copy link
Copy Markdown
Contributor Author

Andrew Waterman (@aswaterman) Sorry, I accidentally closed the PR just now. I have reopened it, could you please help restart the CI.

@aswaterman
Andrew Waterman (aswaterman) merged commit 53c5af5 into riscv:master Dec 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants