ext-p: fix typo - #414
Merged
Andrew Waterman (aswaterman) merged 1 commit intoApr 30, 2026
Merged
Conversation
The opcode[1:0] should 3 but not 2 for 32bits encoding Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
Contributor
Author
|
It should be caused by Ctrl-a + Ctrl-a in vim |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 97.08% 97.09%
=======================================
Files 14 14
Lines 926 929 +3
=======================================
+ Hits 899 902 +3
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Andrew Waterman (@aswaterman) The part is included in riscv-software-src/riscv-isa-sim#2246 |
Andrew Waterman (aswaterman)
approved these changes
Apr 30, 2026
Andrew Waterman (aswaterman)
left a comment
Andrew Waterman (aswaterman)
left a comment
Member
There was a problem hiding this comment.
It should be caused by Ctrl-a + Ctrl-a in vim
Happens to the best of us :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opcode[1:0] should 3 but not 2 for 32bits encoding