feat: publish TwinDuel team membership

Author: flemming-n-larsen

README.md

@@ -13,7 +13,7 @@ Read [CONTRIBUTING.md](CONTRIBUTING.md) for the full submission, ownership, lice
 
 ## Catalog
 
-`bots/index.json` and `bots/owners.json` are generated by CI and must never be edited in a pull request. A catalog entry contains the bot identity, owner, source path, source-tree SHA-256, and active lifecycle status. Only `active` entries are eligible for matchmaking.
+`bots/index.json` and `bots/owners.json` are generated by CI and must never be edited in a pull request. A catalog entry contains the bot identity, owner, source path, source-tree SHA-256, active lifecycle status, and `teamMembers`. Individual bots publish an empty member list; a TwinDuel team publishes exactly two active member identities. Only `active` entries are eligible for matchmaking.
 
 This repository is designed to be forkable: its validator is standard-library Python and GitHub Actions only invokes that script. The only forge seam is the workflow that supplies the pull-request author to the validator and publishes generated files after merge.
 Source-only catalog for ranked Tank Royale Rumble bots

scripts/validate_bot.py

@@ -43,6 +43,19 @@ class Bot:
     def name(self) -> str:
         return str(self.config["name"])
 
+    @property
+    def display_name(self) -> str:
+        return f"{self.name} {self.config['version']}"
+
+    @property
+    def platform(self) -> str:
+        return PLATFORMS[self.platform_key][1]
+
+    @property
+    def team_member_names(self) -> list[str]:
+        value = self.config.get("teamMembers", [])
+        return list(value) if isinstance(value, list) else []
+
 
 def read_json(path: Path) -> dict[str, Any]:
     try:
@@ -82,17 +95,24 @@ def bot_directories(root: Path) -> list[tuple[str, Path]]:
 def validate_bot(platform_key: str, directory: Path, *, smoke: bool) -> Bot:
     source_extension, expected_platform, api_token = PLATFORMS[platform_key]
     config = read_json(directory / f"{directory.name}.json")
-    for field in ("name", "version", "authors", "platform", "license"):
+    for field in ("name", "version", "authors", "license"):
         if not config.get(field):
             raise ValidationError(f"{directory}: missing required `{field}` in {directory.name}.json")
     if config["name"] != directory.name:
         raise ValidationError(f"{directory}: directory name must equal config name `{config['name']}`")
-    if config["platform"] != expected_platform:
-        raise ValidationError(f"{directory}: `{platform_key}` entries require platform `{expected_platform}`")
     if not isinstance(config["authors"], list) or not all(isinstance(author, str) and author for author in config["authors"]):
         raise ValidationError(f"{directory}: `authors` must be a non-empty list of display names")
     if config["license"] not in ALLOWED_LICENSES:
         raise ValidationError(f"{directory}: `license` must be one of {', '.join(sorted(ALLOWED_LICENSES))}")
+    if "teamMembers" in config:
+        members = config["teamMembers"]
+        if not isinstance(members, list) or len(members) != 2 or not all(isinstance(member, str) and member for member in members):
+            raise ValidationError(f"{directory}: `teamMembers` must contain exactly two directory names")
+        return Bot(directory, platform_key, config, tree_hash(directory))
+    if not config.get("platform"):
+        raise ValidationError(f"{directory}: missing required `platform` in {directory.name}.json")
+    if config["platform"] != expected_platform:
+        raise ValidationError(f"{directory}: `{platform_key}` entries require platform `{expected_platform}`")
     for suffix in (".sh", ".cmd"):
         if not (directory / f"{directory.name}{suffix}").is_file():
             raise ValidationError(f"{directory}: missing required {directory.name}{suffix} boot script")
@@ -118,6 +138,17 @@ def validate_bot(platform_key: str, directory: Path, *, smoke: bool) -> Bot:
     return bot
 
 
+def validate_team_members(bots: list[Bot]) -> None:
+    by_directory = {bot.directory: bot for bot in bots}
+    for team in (bot for bot in bots if bot.team_member_names):
+        for member_name in team.team_member_names:
+            member = by_directory.get(team.directory.parent / member_name)
+            if member is None:
+                raise ValidationError(f"{team.directory}: unknown team member `{member_name}`")
+            if member.team_member_names:
+                raise ValidationError(f"{team.directory}: team member `{member_name}` cannot be another team")
+
+
 def smoke_bot(bot: Bot) -> None:
     script = bot.directory / f"{bot.name}.sh"
     python_executable = str(Path(sys.executable))
@@ -212,9 +243,11 @@ def generated_catalog(bots: list[Bot], root: Path, owner: str) -> tuple[dict[str
         elif current is None:
             history.append(entry)
     active = []
+    by_directory = {bot.directory: bot for bot in bots}
     for bot in sorted(bots, key=lambda item: item.name.casefold()):
         previous = next((entry for entry in existing_catalog.get("bots", []) if entry.get("name") == bot.name and entry.get("version") == bot.config["version"]), None)
-        active.append({"name": bot.name, "version": bot.config["version"], "platform": bot.config["platform"], "path": bot.directory.relative_to(root).as_posix(), "sourceHash": bot.source_hash, "owner": owner_by_bot.get(bot.name, owner), "authors": bot.config["authors"], "addedAt": previous.get("addedAt", today) if previous else today, "status": "active"})
+        team_members = [by_directory[bot.directory.parent / name].display_name for name in bot.team_member_names]
+        active.append({"name": bot.name, "version": bot.config["version"], "platform": bot.platform, "path": bot.directory.relative_to(root).as_posix(), "sourceHash": bot.source_hash, "owner": owner_by_bot.get(bot.name, owner), "authors": bot.config["authors"], "addedAt": previous.get("addedAt", today) if previous else today, "status": "active", "teamMembers": team_members})
     catalog = {"schemaVersion": 1, "generatedAt": datetime.now(UTC).replace(microsecond=0).isoformat().replace("+00:00", "Z"), "commit": os.environ.get("GITHUB_SHA", "local"), "bots": history + active}
     return catalog, owner_data
 
@@ -229,6 +262,7 @@ def main() -> int:
     root = arguments.root.resolve()
     try:
         bots = [validate_bot(platform, directory, smoke=arguments.smoke) for platform, directory in bot_directories(root)]
+        validate_team_members(bots)
         check_governance(bots, root, arguments.owner)
         if arguments.generate:
             catalog, owners = generated_catalog(bots, root, arguments.owner)

tests/test_validate_bot.py

@@ -36,6 +36,18 @@ def add_bot(self, name: str) -> None:
         config_path.unlink()
         (destination / f"{name}.json").write_text(json.dumps(config), encoding="utf-8")
 
+    def add_team(self, name: str, members: list[str]) -> None:
+        destination = self.root / "bots" / "python" / name
+        destination.mkdir()
+        config = {
+            "name": name,
+            "version": "1.0",
+            "authors": ["Test author"],
+            "license": "Apache-2.0",
+            "teamMembers": members,
+        }
+        (destination / f"{name}.json").write_text(json.dumps(config), encoding="utf-8")
+
     def test_valid_submission_generates_an_active_catalog_entry(self) -> None:
         result = self.run_validator("--smoke", "--generate")
         self.assertEqual(0, result.returncode, result.stderr)
@@ -94,6 +106,26 @@ def test_registered_secondary_account_can_update_and_is_preserved(self) -> None:
         regenerated_owners = json.loads(owners_path.read_text(encoding="utf-8"))
         self.assertEqual(["primary", "secondary"], regenerated_owners["owners"][0]["accounts"])
 
+    def test_RBC004_IntegrationPositive_team_members_are_published_as_catalog_identities(self) -> None:
+        self.add_bot("Nova")
+        self.add_team("OrbitNova", ["Orbit", "Nova"])
+
+        result = self.run_validator("--generate")
+
+        self.assertEqual(0, result.returncode, result.stderr)
+        catalog = json.loads((self.root / "bots" / "index.json").read_text(encoding="utf-8"))
+        entries = {entry["name"]: entry for entry in catalog["bots"] if entry["status"] == "active"}
+        self.assertEqual(["Orbit 1.0.2", "Nova 1.0.2"], entries["OrbitNova"]["teamMembers"])
+        self.assertEqual([], entries["Orbit"]["teamMembers"])
+
+    def test_RBC004_IntegrationNegative_unknown_team_member_is_rejected(self) -> None:
+        self.add_team("BrokenTeam", ["Orbit", "Missing"])
+
+        result = self.run_validator("--generate")
+
+        self.assertNotEqual(0, result.returncode)
+        self.assertIn("unknown team member `Missing`", result.stderr)
+
 
 if __name__ == "__main__":
     unittest.main()