Repository navigation
Commit 04e30f0
fix(helm): harden dnsConfig helper per review
Address CodeRabbit feedback on the dnsConfig helper:
- When dnsPolicy is "None", Kubernetes requires at least one nameserver
(searches/options alone are rejected by the API server). Tighten the
guard to require .nameservers specifically instead of any config field.
- Tolerate a null/missing dnsConfig object (`and . .enabled`) and default
.policy to "ClusterFirst" when unset, so the template never panics or
emits an empty `dnsPolicy: ""`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent dd2c56b commit 04e30f0
1 file changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
22 | 23 | | |
23 | | - | |
24 | | - | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | | - | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments