Repository navigation
fix: do not fail get_pod_logs on bytes that are not valid UTF-8 - #2207
Open
mayuriphad wants to merge 2 commits into
Open
mayuriphad wants to merge 2 commits into
mayuriphad wants to merge 2 commits into
Conversation
Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Author
|
Hi, just a gentle ping on this PR. It's ready for review whenever you have time, and I'm happy to make any changes you'd like. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_pod_logsdecoded the pod log bytes in strict UTF-8 mode and only caughtApiException. A single byte that is not valid UTF-8 (for example the raw0xffjsoniter writes into its error messages) raisedUnicodeDecodeError, which failed the whole action: the Log Viewer showsACTION_UNEXPECTED_ERROR (Error code: 4700)andlogs_enricherreturns no logs, whilekubectl logsprints the same pod fine.The logs are now decoded with
errors="replace", so the invalid byte becomes�and the rest of the logs are returned.Fixes #2201
Added
tests/test_pod_logs_decoding.py; the invalid-byte case fails withUnicodeDecodeErrorwithout the change.