Prepare Trayffeine 1.2.0 presence diagnostics - #14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3b5cb59a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| finally: | ||
| kernel32.GlobalUnlock(handle) | ||
|
|
||
| if not user32.OpenClipboard(None): |
There was a problem hiding this comment.
Use a non-null clipboard owner
On Windows, when a user selects Support > Copy diagnostics, this opens the clipboard with a NULL owner and then calls EmptyClipboard before SetClipboardData. The Win32 clipboard docs note that this sequence leaves the clipboard owner NULL and can make SetClipboardData fail, so the new diagnostics action can log failure without copying anything. Pass a real owner HWND, such as the tray window or a hidden helper window, before emptying the clipboard.
Useful? React with 👍 / 👎.
Summary
Test Plan
.venv\Scripts\ruff.exe check ..venv\Scripts\python.exe -m pytestgit diff --checkNotes