Prepare MSIX Store packaging - #15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f61469d896
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| _disable_start_with_windows() | ||
|
|
||
| state = _await_winrt_operation(task.request_enable_async()) |
There was a problem hiding this comment.
When the packaged startup task is DISABLED_BY_USER and the persisted preference is still true, startup reaches this line and calls request_enable_async() before reconciling the preference. This unnecessarily attempts to reverse the Task Manager choice and produces a logged startup exception; inspect task.state first and reconcile the saved preference to false without issuing the request.
AGENTS.md reference: AGENTS.md:L185-L188
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Why
Trayffeine is the pilot for a future Microsoft Store submission. This prepares the smallest safe package path without publishing a release, changing WinGet, or bumping version 1.2.0.
Validation
ruff check .pytest— 89 passedpackaging/msix/build.ps1-Clean; both completed, and staging/verification sentinel files were removedCI,MSIX Preview Build, and legacyPreview Build— all successful onf526c3af526c3a— no major issues foundgit diff --check origin/mainNotes
0x80073CFF; Developer Mode and sideload/security policy were not changed