Fixed custom traversal and typehints in tests.

Author: danielmorell

pyproject.toml

@@ -48,6 +48,7 @@ dependencies = [
 test = [
     "blinker",
     "httpx",
+    "packaging",
     "pytest",
     "python-multipart",
     "webob",

rollbar/__init__.py

@@ -628,7 +628,8 @@ def wrapper(event, context):
 
 
 def report_exc_info(
-        exc_info: tuple[type[BaseException], BaseException, types.TracebackType] | tuple[None, None, None] | None = None,
+        exc_info: tuple[type[BaseException], BaseException, types.TracebackType | None] | tuple[
+            None, None, None] | None = None,
         request=None, extra_data=None, payload_data=None, level=None, **kw):
     """
     Reports an exception to Rollbar, using exc_info (from calling sys.exc_info())

rollbar/lib/traverse.py

@@ -173,9 +173,12 @@ def traverse(
         elif obj_type is PATH:
             return path_handler(obj, key=key)
         elif obj_type is DEFAULT:
-            for handler_type, handler in custom_handlers.items():
-                # Only attempt isinstance checks when the key is a type (or tuple of types).
-                if isinstance(handler_type, (type, tuple)) and isinstance(obj, handler_type):
+            for handler_type, handler in (custom_handlers or {}).items():
+                # Check the full module path first e.g. "my_module.MyClass" or "builtin.complex"
+                if f"{type(obj).__module__}.{type(obj).__name__}" == handler_type:
+                    return handler(obj, key=key)
+                # Fallback to just the name e.g. "MyClass" or "complex".
+                if type(obj).__name__ == handler_type:
                     return handler(obj, key=key)
     except:
         # use the default handler for unknown object types

rollbar/lib/type_info.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Hashable
+from typing import Hashable, Any
 
 from rollbar.lib import binary_type, string_types
 
@@ -20,7 +20,7 @@
 PATH = 7
 
 
-def get_type(obj):
+def get_type(obj: Any) -> int:
     if isinstance(obj, (string_types, binary_type)):
         return STRING
 

rollbar/test/starlette_tests/test_middleware.py

@@ -307,7 +307,7 @@ async def root(original_request):
             return PlainTextResponse('OK')
 
         app = Starlette(routes=[
-            Route('/{param}', endpoint=root),
+            Route('/', endpoint=root),
         ])
         app.add_middleware(ReporterMiddleware)