Add config.js_exclude_paths to skip rollbar.js injection on some paths - #1208
Open
bugthing wants to merge 2 commits into
Open
Add config.js_exclude_paths to skip rollbar.js injection on some paths#1208bugthing wants to merge 2 commits into
bugthing wants to merge 2 commits into
Conversation
Rollbar::Middleware::Js currently injects the rollbar.js snippet into every 200 HTML response app-wide with no way to opt individual paths out. This is a problem for routes that serve their own restrictive Content-Security-Policy (e.g. rswag-ui's Swagger UI page), where the injected script tags can't load cdn.rollbar.com and just fail silently. js_exclude_paths accepts an array of String (matched as a PATH_INFO prefix) or Regexp entries. Defaults to [] for full backward compatibility.
bugthing
marked this pull request as ready for review
August 25, 2026 16:43
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fbb3c1948
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Regexp#match? was added in Ruby 2.4 and isn't available on Ruby 2.0-2.3, which the gemspec still declares support for. Using it raised NoMethodError on older rubies, which the outer rescue silently swallowed, disabling JS injection entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollbar::Middleware::Jscurrently injects the rollbar.js snippet into every200HTML response app-wide, with no way to opt individual paths out.The poblem is for routes that serve their own restrictive
Content-Security-Policy, for examplerswag-ui's Swagger UI page sets a hardcoded, narrow CSP (script-src 'self' 'unsafe-inline') that doesn't allowcdn.rollbar.com. The injected snippet's breaks their CSPChange
Adds
config.js_exclude_paths, an array ofString(matched as aPATH_INFOprefix) orRegexpentries. When a request's path matches any entry,Rollbar::Middleware::Jsskips injecting the config/snippet<script>tags for that response, using the same short-circuit as the existingenabled?/attachment?/streaming?checks inadd_js?.Defaults to
[], so this is fully backward compatible — no behavior change unless the option is explicitly set.