Skip to content

Commit 23663b3

Browse files
authored
fix(logback): restrict recursive logger suppression to Rollbar package (#376)
* fix(logback): restrict recursive logger suppression to Rollbar package * fix(logback): restrict recursive logger suppression to Rollbar package * fix(logback): remove hidden Unicode characters * fix(logback): remove duplicate logger boundary check block
1 parent 4bd68c5 commit 23663b3

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

rollbar-logback/src/main/java/com/rollbar/logback/RollbarAppender.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public String provide() {
110110

111111
@Override
112112
protected void append(ILoggingEvent event) {
113-
if (event.getLoggerName() != null && event.getLoggerName().startsWith(PACKAGE_NAME)) {
113+
if (isRollbarLogger(event.getLoggerName())) {
114114
addWarn("Recursive logging");
115115
return;
116116
}
@@ -124,6 +124,15 @@ protected void append(ILoggingEvent event) {
124124

125125
}
126126

127+
private static boolean isRollbarLogger(String loggerName) {
128+
if (loggerName == null) {
129+
return false;
130+
}
131+
132+
return PACKAGE_NAME.equals(loggerName)
133+
|| loggerName.startsWith(PACKAGE_NAME + ".");
134+
}
135+
127136
@Override
128137
public void stop() {
129138
super.stop();

0 commit comments

Comments
 (0)