Fixed vulnerable to Cross Site Request Forgery (CSRF) - #129
Closed
jerrybarry wants to merge 1 commit into
Closed
Conversation
| } | ||
|
|
||
| // Additional security check - ensure we're in admin context | ||
| if (!is_admin()) { |
Collaborator
There was a problem hiding this comment.
Is a REST endpoint in the admin context?
| 'permission_callback' => '__return_true', | ||
| 'permission_callback' => function() { | ||
| // Check if user is logged in and has manage_options capability | ||
| return is_user_logged_in() && current_user_can('manage_options'); |
| public static function flashRedirect($type, $message) | ||
| { | ||
| // Security check - ensure user has proper capabilities | ||
| if (!current_user_can('manage_options')) { |
Collaborator
There was a problem hiding this comment.
Is there a reason we are adding this here when it is only called from restoreDefaultsAction() which has the same check?
| } | ||
|
|
||
| // Verify nonce if provided (for admin menu link) | ||
| if (isset($_GET['_wpnonce']) && !wp_verify_nonce($_GET['_wpnonce'], 'rollbar_wp_admin_link')) { |
Collaborator
There was a problem hiding this comment.
With this check being optional, what is the benefit of having it?
|
@jerrybarry fyi :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review