Skip to content

Commit 3277276

Browse files
AI Agentclaude
andcommitted
SDK-613: make the build matrix fail the run, and swap node 21 for 24
Addresses both review comments on the CI workflow. `continue-on-error: true` sat on the `build` job, so every matrix leg could fail while the run still reported success -- the reason the `npm ci` breakage in this branch showed up as a green run. Removed it, so a regression in `Lint`, `Build`, `Test` or the new `Test examples` step now fails CI. `strategy.fail-fast: false` takes its place, which is what the original setting was presumably reaching for: every runtime still reports instead of being cancelled by the first failure. Node 21 has been end-of-life since June 2024, so that slot becomes node 24 (paired with npm 11, the version it bundles). The matrix is now node 20 -- the floor Next.js 16 supports, and what the examples pin -- plus the two maintained LTS lines, 22 and 24. Verified: the full CI sequence (`install:all -- ci`, `lint`, `lint:examples`, `build:all` across all four examples, `test`, `test:examples`) passes locally on node 24.21.0 with npm 11, as it already does on 22.23.2 with npm 10. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 6c2372d commit 3277276

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,19 @@ jobs:
1313
runs-on: ubuntu-latest
1414

1515
strategy:
16+
# Let every runtime report rather than cancelling its siblings on the
17+
# first failure -- but the job itself must still fail the run.
18+
fail-fast: false
1619
matrix:
1720
include:
18-
# Next.js 16 (used by the examples) requires node >= 20.9.
21+
# Next.js 16 (used by the examples) requires node >= 20.9, so 20 is
22+
# the floor. 22 and 24 are the maintained LTS lines.
1923
- node: 20
2024
npm: 10
21-
- node: 21
22-
npm: 10
2325
- node: 22
2426
npm: 10
25-
26-
continue-on-error: true
27+
- node: 24
28+
npm: 11
2729

2830
steps:
2931
- name: Checkout

0 commit comments

Comments
 (0)