Commit 3277276
SDK-613: make the build matrix fail the run, and swap node 21 for 24
Addresses both review comments on the CI workflow.
`continue-on-error: true` sat on the `build` job, so every matrix leg
could fail while the run still reported success -- the reason the
`npm ci` breakage in this branch showed up as a green run. Removed it,
so a regression in `Lint`, `Build`, `Test` or the new `Test examples`
step now fails CI. `strategy.fail-fast: false` takes its place, which
is what the original setting was presumably reaching for: every runtime
still reports instead of being cancelled by the first failure.
Node 21 has been end-of-life since June 2024, so that slot becomes node
24 (paired with npm 11, the version it bundles). The matrix is now node
20 -- the floor Next.js 16 supports, and what the examples pin -- plus
the two maintained LTS lines, 22 and 24.
Verified: the full CI sequence (`install:all -- ci`, `lint`,
`lint:examples`, `build:all` across all four examples, `test`,
`test:examples`) passes locally on node 24.21.0 with npm 11, as it
already does on 22.23.2 with npm 10.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 6c2372d commit 3277276
1 file changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | | - | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
22 | | - | |
23 | 25 | | |
24 | 26 | | |
25 | | - | |
26 | | - | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
0 commit comments