Skip to content

Fixing "git dubious ownership in repository" - #308

Open
GuillaumeHullin wants to merge 1 commit into
ronivay:masterfrom
GuillaumeHullin:master
Open

Fixing "git dubious ownership in repository"#308
GuillaumeHullin wants to merge 1 commit into
ronivay:masterfrom
GuillaumeHullin:master

Conversation

@GuillaumeHullin

Copy link
Copy Markdown

The main purpose of the PR is to fix the "git dubious ownership in repository" error mentioned in #307 which would cause re-compiling of XO each time xo-install.sh --update was run.
The cause of the issue is the use of runcmd "chown -R $XOUSER:$XOUSER $INSTALLDIR/xo-builds/xen-orchestra-$TIME"... but I'm guessing that there was a very good reason why it was done. So I used runuser because sudo might not be available. The command is part of the util-linux package... which should be available on most distros.

On other point of the PR is to use the -C switch of git as documented in Git doc. This is to avoid unnecessary directory changes in the script.

Tested with Debian 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant