Add reverse proxy options to generated XO configuration - #372
Open
m0canu1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three optional
xo-install.cfgsettings for Xen Orchestra deployments behind a reverse proxy:PUBLIC_URLUSE_FORWARDED_HEADERSCOOKIE_SECUREWhen
CONFIGUPDATE=true, the installer writes the selected values to the generated xo-server configuration:http.publicUrlhttp.useForwardedHeadershttp.cookies.secureMotivation
XO supports these settings for reverse-proxy and TLS-termination deployments. Exposing them in
xo-install.cfglets users retain installer-managed configuration instead of manually editingconfig.tomlafter updates.The change is proxy-agnostic; it adds no Caddy, nginx, or Traefik-specific behavior.
Security
USE_FORWARDED_HEADERS=trueis opt-in. It must be enabled only when xo-server’s HTTP listener is not directly reachable by untrusted clients, because forwarded headers can otherwise be spoofed.Scope
I am aware of #265 and the preference to avoid surfacing every xo-server setting. This proposal intentionally stays limited to the three settings needed for the common reverse-proxy/TLS-termination deployment pattern.