Skip to content

[clang] Switch to upstream patch for AST generation - #23166

Open
hahnjo wants to merge 3 commits into
root-project:masterfrom
hahnjo:refactor-generation
Open

[clang] Switch to upstream patch for AST generation#23166
hahnjo wants to merge 3 commits into
root-project:masterfrom
hahnjo:refactor-generation

Conversation

@hahnjo

@hahnjo hahnjo commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@hahnjo hahnjo self-assigned this Aug 27, 2026
@hahnjo hahnjo added in:Cling clean build Ask CI to do non-incremental build on PR labels Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    24 files      24 suites   3d 23h 16m 28s ⏱️
 3 885 tests  3 885 ✅ 0 💤 0 ❌
83 203 runs  83 203 ✅ 0 💤 0 ❌

Results for commit 4b5e7f3.

♻️ This comment has been updated with latest results.

@vgvassilev

vgvassilev commented Aug 27, 2026

Copy link
Copy Markdown
Member

IIRC, that came from CMSSW scale deployments.

@hahnjo

hahnjo commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

IIRC, that came from CMSSW scale deployments.

If you have pointers what to look at, I will take it. For the moment, this looks like a bug in the code if you register multiple ExternalASTSources, which we do in Cling. Without either of the fixes, it actually errors out during build because some Redelcarables are not found from deserialization.

@hahnjo
hahnjo force-pushed the refactor-generation branch from 714b771 to 9f63c51 Compare September 25, 2026 11:23
@hahnjo

hahnjo commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

ping @vgvassilev, llvm/llvm-project#219189 landed upstream a while ago

@hahnjo hahnjo changed the title [clang] Test upstream patch for AST generation [clang] Upstream patch for AST generation Sep 25, 2026
hahnjo added 3 commits October 19, 2026 11:53
@hahnjo
Revert "[cxxmodules] Refactor generation counter in LLVM"
f7de3d3 
This reverts commit 75e3a39.
@hahnjo
[clang][AST] Fix generation with multiple external sources
c994b8e 
ExternalASTSource::incrementGeneration returns the OldGeneration,
which must be taken into account in case it is delegated to the
topmost external source.

This obsoletes a long-standing downstream patch in Cling that was
previously submitted in https://reviews.llvm.org/D39714.
@hahnjo
[llvm-project] Bump to tag ROOT-llvm22-20260919-01
4b5e7f3
@hahnjo hahnjo changed the title [clang] Upstream patch for AST generation [clang] Switch to upstream patch for AST generation Oct 19, 2026
@hahnjo
hahnjo force-pushed the refactor-generation branch from 9f63c51 to 4b5e7f3 Compare October 19, 2026 10:14
@hahnjo
hahnjo marked this pull request as ready for review October 19, 2026 10:14
@hahnjo
hahnjo requested a review from vgvassilev as a code owner October 19, 2026 10:14
@hahnjo hahnjo added this to the 6.42.00 milestone Oct 19, 2026
vgvassilev
vgvassilev approved these changes Oct 19, 2026
View reviewed changes

@vgvassilev vgvassilev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev

vgvassilev commented Oct 19, 2026

Copy link
Copy Markdown
Member

ping @vgvassilev, llvm/llvm-project#219189 landed upstream a while ago

I believe you do not need approval for such cases -- just go ahead next time.

@hahnjo

hahnjo commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

I believe you do not need approval for such cases -- just go ahead next time.

I need approval, otherwise I cannot merge the PR 😉

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees

@hahnjo hahnjo

Labels

clean build Ask CI to do non-incremental build on PR in:Cling pr:squash on merge

Projects

None yet

Milestone

6.42.00

Development

Successfully merging this pull request may close these issues.

2 participants

@hahnjo @vgvassilev