|
21 | 21 | # fujitatomoya/libabigail-action (abidiff), one job per library, |
22 | 22 | # 5. applies REP-0009 policy automatically: released distros (humble/jazzy/kilted/lyrical) |
23 | 23 | # fail on an incompatible ABI break, rolling is advisory only, |
24 | | -# 6. surfaces per-library verdicts as sticky PR comments, labels, and a pass/fail check. |
| 24 | +# 6. surfaces the verdict as a pass/fail check and uploads one report bundle |
| 25 | +# (abidiff report + verdict.json) per library. |
| 26 | +# |
| 27 | +# The sticky PR comment and the "ABI compatible" / "ABI break" labels are NOT |
| 28 | +# posted from here (publish: workflow-run). Most rclcpp pull requests come from |
| 29 | +# forks, and on pull_request events from a fork GitHub gives this workflow a |
| 30 | +# read-only token regardless of the permissions requested below, so any write |
| 31 | +# to the PR would fail. abi-report.yaml runs on workflow_run once this workflow |
| 32 | +# completes and publishes the comment and labels with a token that may write. |
25 | 33 | # |
26 | 34 | # Paired changes in other repositories (e.g. an rcl PR this PR depends on) are |
27 | 35 | # declared by the PR author in the PR description and applied to the PR side |
|
41 | 49 |
|
42 | 50 | jobs: |
43 | 51 | abi: |
| 52 | + # Nothing is written to the pull request from this workflow; the report |
| 53 | + # workflow holds the write permissions. |
44 | 54 | permissions: |
45 | 55 | contents: read |
46 | | - pull-requests: write |
47 | | - issues: write |
48 | 56 | uses: fujitatomoya/ros2-abi-action/.github/workflows/check.yml@main |
49 | 57 | with: |
50 | 58 | # Colcon package names to build (whitespace-separated); no single package |
|
63 | 71 | distro: auto |
64 | 72 | # auto -> REP-0009: strict on released distros, advisory on rolling. |
65 | 73 | policy: auto |
| 74 | + # Leave the PR comment and labels to abi-report.yaml (workflow_run), so |
| 75 | + # pull requests from forks get them too. |
| 76 | + publish: workflow-run |
0 commit comments