Conversation
Consolidate onboarding, development, feature, and maintainer guidance, and build the documentation site through the shared workflow.
divyarajmasani
left a comment
There was a problem hiding this comment.
I reviewed the PR, I believe the documentation could you more user friendly language. We need not make every paragraph as short as possible.
Also, there were some good documentation overridden by a short version as well, let's revisit these changes again and ensure we do not introduce changes where it doesn't require.
| Use this starter to create a named WordPress block theme. It provides the theme | ||
| structure, examples, asset pipeline, checks, and optional development features | ||
| needed for a new project. |
There was a problem hiding this comment.
| Use this starter to create a named WordPress block theme. It provides the theme | |
| structure, examples, asset pipeline, checks, and optional development features | |
| needed for a new project. | |
| This is a starter WordPress blocks theme. It provides the | |
| structure, examples, asset pipeline, checks, and optional development features | |
| needed for building a new blocks theme. |
| Runtime abstractions ship separately in the | ||
| [`rtcamp/wp-framework`](https://github.com/rtCamp/wp-framework) Composer package. | ||
| The init and feature-scaffolding workflows use | ||
| [`@rtcamp/wp-tooling`](https://github.com/rtCamp/wp-tooling). |
There was a problem hiding this comment.
This sentence could be more direct,
| Runtime abstractions ship separately in the | |
| [`rtcamp/wp-framework`](https://github.com/rtCamp/wp-framework) Composer package. | |
| The init and feature-scaffolding workflows use | |
| [`@rtcamp/wp-tooling`](https://github.com/rtCamp/wp-tooling). | |
| This theme uses [`rtcamp/wp-framework`](https://github.com/rtCamp/wp-framework) as a runtime dependency and ships with [`@rtcamp/wp-tooling`](https://github.com/rtCamp/wp-tooling) for streamlined project initialization and feature scaffolding. |
|
|
||
| ## AI tooling | ||
| - **Claude Code:** retained skills in [`.claude/skills/`](.claude/skills/) — `/init`, `/scaffold`, and `/setup`. | ||
| - **GitHub Copilot:** `/init` and `/scaffold` prompts are available while setting up this source repository; initialization removes `.github` from the resulting project. |
There was a problem hiding this comment.
I believe this would not be the expected outcome, to remove .github means it will also remove default issue templates, workflows and more.
Please, confirm and we could look are updating this behaviour so to retain necessary defaults.
There was a problem hiding this comment.
Yes this is the current behaviour cleanup.targets in bin/scaffold.config.js lists .github wholesale, and the shared cleanup step does a recursive delete on it, so init does remove all of .github today, not just the Copilot prompts.
That said, you're right that it's not the ideal outcome — issue templates, PULL_REQUEST_TEMPLATE.md, dependabot.yml, release.yml, and the workflows get removed along with the AI files. We can narrow the cleanup target so only the AI-specific paths
| devDependencies: { | ||
| '@rtcamp/tailwind-config': '^0.1.0', | ||
| '@rtcamp/tailwind-config': | ||
| 'github:rtCamp/wp-tooling#npm/tailwind-config', |
There was a problem hiding this comment.
I believe this change is temporary and will be removed once the package is published. Is that true?
If so, need to add a section specifically for such changes, or libs that are using internal repos.
There was a problem hiding this comment.
Yes, that's correct this is temporary. @rtcamp/tailwind-config isn't published to npm yet, so pinning ^0.1.0 would fail to resolve; pointing at the wp-tooling GitHub ref is the only way --enable=tailwind actually works right now. Once the package is published, we'll switch this back to a normal semver range.
Went with this over documenting a manual separate-download step for tailwind-config because that would push extra setup work onto every user enabling Tailwind, and we'd have to keep the /init skill and initialization.md/tailwind.md in sync with a manual step that's only needed until publishing happens more moving parts for something that resolves itself once the package ships.
| name: Documentation | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
The documentation action was updated, check the final workflow here,
https://github.com/rtCamp/wp-framework/blob/main/.github/workflows/documentation.yml
| Create an **Acme Blog** theme, activate it in local WordPress, and see a source | ||
| edit on the frontend. Run commands from the theme directory unless a step says |
There was a problem hiding this comment.
This paragraph should read more natural and informative to the user, for what they can expect or what this is about.
The sentence structure looks incomplete and short.
| Have Git, Composer 2, PHP 8.2+, Node and npm matching [`.nvmrc`](../.nvmrc), and a | ||
| running Docker installation for the recommended `wp-env` route. Use `nvm` or | ||
| another Node version manager to select the version in `.nvmrc`. | ||
|
|
||
| ```bash | ||
| git --version | ||
| composer --version | ||
| php --version | ||
| node --version | ||
| npm --version | ||
| docker info | ||
| ``` |
There was a problem hiding this comment.
Could become a pre-requisite section, may not need the commands. Though if any particular version is needed can add that.
| At this point, `vendor/autoload.php` and `node_modules/@rtcamp/wp-tooling` should | ||
| exist. Resolve installation errors before continuing; see |
There was a problem hiding this comment.
I think the first sentence is redundant,
| At this point, `vendor/autoload.php` and `node_modules/@rtcamp/wp-tooling` should | |
| exist. Resolve installation errors before continuing; see | |
| Resolve installation errors before continuing; see |
There was a problem hiding this comment.
I find the previous wording in the documentation to be more user friendly, only check the asset-building-process for the correctness and add what's missing.
There was a problem hiding this comment.
Most of the previous document content seems to be removed, please review the wording. and document flow. Do not remove any information that is simple to understand by the users.
Description
Create a clear documentation journey for Theme Elementary and publish it through the shared Docusaurus workflow.
Technical Details
README.md,DEVELOPMENT.md, andCONTRIBUTING.mdas concise entry points.theme-elementary-v2branch and documentation sidebar.Checklist
docs/internal/.Fixes/Covers Issue
Fixes #768
Covers #769, #770, #771, #772, #773, #774, #775, #776