Skip to content

Commit d5ed8ea

Browse files
committed
restores the canonical parse-then-Store#complete lifecycle
1 parent bd045fe commit d5ed8ea

2 files changed

Lines changed: 20 additions & 0 deletions

File tree

‎lib/rdoc/rubygems_hook.rb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ def generate
198198
@rdoc.options = parse_options
199199
@rdoc.store = Store.new(parse_options)
200200
@rdoc.parse_files parse_options.files
201+
@rdoc.store.complete parse_options.visibility
201202
end
202203

203204
document 'ri', options, @ri_dir if

‎test/rdoc/rdoc_rubygems_hook_test.rb‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,25 @@ def test_generate_all
146146
assert_equal 'MyTitle', rdoc.store.main
147147
end
148148

149+
def test_generate_completes_store
150+
File.write File.join(@a.gem_dir, 'lib', 'a.rb'), <<~RUBY
151+
class A
152+
def public_method; end
153+
154+
private def private_method; end
155+
end
156+
157+
class Hidden # :nodoc:
158+
end
159+
RUBY
160+
161+
@hook.generate
162+
163+
store = @hook.instance_variable_get(:@rdoc).store
164+
assert_equal %w[public_method], store.find_class_named('A').method_list.map(&:name)
165+
assert_nil store.find_class_named('Hidden')
166+
end
167+
149168
def test_generate_rdoc_with_page_cross_reference
150169
@hook.generate_rdoc = true
151170
@hook.generate_ri = false

0 commit comments

Comments
 (0)