feat: show module links and games in order on the student home

Students see each module's contents through a single ordered list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: sean-dickinson

app/controllers/student_homes_controller.rb

@@ -9,7 +9,7 @@ def index
       .order("programs.name")
     @active_program = @classroom_programs.find { |cp| cp.id.to_s == params[:classroom_program_id] } || @classroom_programs.first
     @published_modules = if @active_program
-      @active_program.classroom_modules.published.includes(content_module: :links)
+      @active_program.classroom_modules.published.includes(content_module: { contents: :contentable })
     else
       []
     end

app/views/student_homes/_content.html.erb

@@ -0,0 +1,4 @@
+<%# locals: (content:) %>
+<li>
+  <%= render "student_homes/contentables/#{content.contentable_name}", contentable: content.contentable %>
+</li>

app/views/student_homes/contentables/_game.html.erb

@@ -0,0 +1,2 @@
+<%# locals: (contentable:) %>
+<%= link_to contentable.title, play_game_path(contentable), class: "link inline-flex items-center gap-1" %>

app/views/student_homes/contentables/_link.html.erb

@@ -0,0 +1,3 @@
+<%# locals: (contentable:) %>
+<%= link_to "#{contentable.title} ↗", safe_external_url(contentable.url),
+      target: "_blank", rel: "noopener noreferrer", class: "link inline-flex items-center gap-1" %>

app/views/student_homes/index.html.erb

@@ -30,15 +30,7 @@
         </summary>
         <div class="collapse-content">
           <ul class="flex flex-col gap-2 pt-2">
-            <% classroom_module.content_module.links.each do |link| %>
-              <li>
-                <%= tag.a link.title + " ↗",
-                          href: safe_external_url(link.url),
-                          target: "_blank",
-                          rel: "noopener noreferrer",
-                          class: "link inline-flex items-center gap-1" %>
-              </li>
-            <% end %>
+            <%= render partial: "student_homes/content", collection: classroom_module.content_module.contents %>
           </ul>
         </div>
       <% end %>

test/controllers/student_homes_controller_test.rb

@@ -18,11 +18,25 @@ class StudentHomesControllerTest < ActionDispatch::IntegrationTest
     assert_select "summary", text: /Introduction to Health/
   end
 
-  test "shows links inside published modules" do
+  test "links open in a new tab" do
     get student_homes_url
     assert_response :success
-    link = content_modules(:one).links.first
-    assert_select "a[target='_blank']", text: /#{link.title}/ if link
+    assert_select "li a[href='#{links(:one).url}'][target='_blank'][rel='noopener noreferrer']", text: /#{links(:one).title}/
+  end
+
+  test "games link to the play page in the same tab" do
+    get student_homes_url
+    assert_response :success
+    assert_select "li a[href='#{play_game_path(games(:one))}']:not([target])", text: games(:one).title
+  end
+
+  test "shows contents in position order" do
+    contents(:one).update!(position: 2)
+    contents(:two).update!(position: 1)
+
+    get student_homes_url
+    titles = listed_titles
+    assert_operator titles.index(links(:one).title), :<, titles.index(games(:one).title)
   end
 
   test "most recently published module has the open attribute" do
@@ -79,4 +93,11 @@ class StudentHomesControllerTest < ActionDispatch::IntegrationTest
     get student_homes_url(classroom_program_id: enrollment.id)
     assert_select "a[role='tab'][aria-selected='true'][href*='classroom_program_id=#{enrollment.id}']"
   end
+
+  private
+
+  # The " ↗" suffix marks external links, so strip it to compare plain titles.
+  def listed_titles
+    css_select("details li a").map { |a| a.text.delete_suffix(" ↗") }
+  end
 end