Skip to content

feat: give contents ownership of module membership and order - #164

Merged
sean-dickinson merged 2 commits into
mainfrom
contentable-v2-membership
Nov 1, 2026
Merged

sean-dickinson merged 2 commits into
mainfrom
contentable-v2-membership

Conversation

@sean-dickinson

@sean-dickinson sean-dickinson commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Layer 1 of 7 in the contentable stack.

Contents now own module membership and order. Links and games lose their content_module columns, and Content gets a position.

  • A link belongs to one content and is deleted with it.
  • A game can be in many modules. If you remove a game from one module, the game stays.
  • New contents and modules go to the end of their siblings.

The module edit page loses its "Add game" button in this layer. Layer 4 (#167) adds the new flow.

Type of change

  • New feature

How Has This Been Tested?

On this branch, bin/rails test, bin/rubocop, bundle exec herb analyze ., npm run lint, Brakeman, and the test seed replant pass. The top branch of the stack passes bin/ci.

🤖 Generated with Claude Code

Links and games join modules only through contents, which append to the end of their siblings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sean-dickinson
sean-dickinson added this pull request to stack #171 October 31, 2026 20:43
Comment thread test/models/content_module_test.rb Resolved
Comment thread test/models/content_test.rb Resolved
Comment thread test/models/content_test.rb Resolved
Comment thread test/models/content_test.rb Resolved
Comment thread app/models/content_module.rb Resolved
Comment thread app/models/content_module.rb Resolved
Comment thread db/seeds.rb Resolved
@sean-dickinson
sean-dickinson marked this pull request as ready for review November 1, 2026 21:28
@sean-dickinson
sean-dickinson merged commit bd87bcb into main Nov 1, 2026
4 of 5 checks passed
@sean-dickinson
sean-dickinson deleted the contentable-v2-membership branch November 1, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant