Include added items in distribution change emails (5666) - #5727
Open
augustocbx wants to merge 1 commit into
Open
augustocbx wants to merge 1 commit into
augustocbx wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5666
Description
Include newly added items and their quantities in distribution change notifications. An addition now counts as a distribution content change, so adding an item by itself sends the partner a change email.
The existing change detection already handles updated and removed items. Extending it for additions keeps the notification path in one place and preserves the current wording for other changes. No dependencies or user guide changes are needed.
Type of change
How Has This Been Tested?
rbenv exec bundle exec rspec spec/services/distribution_content_change_service_spec.rb spec/services/distribution_update_service_spec.rb spec/controllers/distributions_controller_spec.rb spec/mailers/distribution_mailer_spec.rb— 46 examples, 0 failures.PATH="$HOME/.rbenv/shims:$PATH" bin/lint— 649 Ruby files inspected with no offenses; 423 ERB files with no errors.rbenv exec bundle exec rspec --format progress— 2,980 examples, 0 failures, 1 pending (existing pending example inPartners::RequestApprovalService).An earlier full-suite run overlapped with another test process and hit a PostgreSQL deadlock in an unrelated donation system spec. That example passed alone, and the clean full-suite run above passed without concurrent test processes.