Skip to content

chore(ActivityShikigami): update as_to_battle_main asset and add backup - #1846

Closed
uvj1010 wants to merge 1 commit into
runhey:devfrom
uvj1010:dev
Closed

uvj1010 wants to merge 1 commit into
runhey:devfrom
uvj1010:dev

Conversation

@uvj1010

@uvj1010 uvj1010 commented Sep 28, 2026

Copy link
Copy Markdown

No description provided.

@uvj1010 uvj1010 closed this Sep 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Findings

  • 未发现未通过项

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Checklist for #1846 · codex · gpt56 · 13.9 AIC · ⌖ 2.58 AIC · ⊞ 12.1K · ◷

@github-actions

Copy link
Copy Markdown
Contributor

Change Summary

  • 替换 tasks/ActivityShikigami/as/as_to_battle_main.png,运行时引用路径保持不变。
  • 新增 as_to_battle_main_bk.png,内容对应替换前的旧资源,但没有被代码或资源元数据引用。
  • assets.py / pages.json 中该识别项的 ROI、阈值 0.8 和页面链路均未调整。

Reconstructed Intent

点击此处展开
  • 这次改动最可能是为了适配活动界面变化,更新“进入主要战斗界面”的模板图片,同时保留旧图以便人工回滚或对照。
  • 预期行为是继续通过同一个识别规则进入战斗主界面,不改变任务流程本身。

Observed Constraints

点击此处展开
  • 新图片必须仍与 roi_front=(302,178,98,111) 及 roi_back=(223,110,238,269) 的坐标约束一致。
  • 在未调整阈值和匹配方法的前提下,新模板需要在目标设备分辨率/缩放和实际活动页面上稳定达到 0.8 匹配阈值。
  • 备份文件只是仓库中的静态副本;当前实现没有自动 fallback,识别失败时不会切换到 _bk 资源。

Intent Alignment

  • 基本一致:变更范围与标题所述意图吻合,运行时仍使用更新后的同名资源,未观察到额外的控制流或导航行为变化。
  • 但“add backup”只实现为保留文件,未形成运行时回退机制;如果意图包含自动容错,则只部分覆盖。

Release Risk

  • 风险等级:中
  • 主要风险集中在模板内容与现有 ROI/0.8 阈值是否仍匹配;资源替换可能导致活动入口无法识别,进而阻塞后续战斗流程。
  • 备份图未接入识别链路,不能降低线上识别失败风险;回滚仍需人工替换资源。
  • PR 状态为 closed,当前 head status 未返回任何 CI 状态,发布前需确认该资源是否实际进入目标发布分支。

Validation Gaps

点击此处展开
  • 未看到该图片在目标分辨率、缩放/渲染差异和活动页面实机截图上的模板匹配验证。
  • 未看到 script_test.py 或等价流程验证,尤其是“活动主页面 → 战斗主界面”的入口识别和失败/超时行为。
  • 未看到对新 PNG 尺寸、裁剪区域与既有 roi_front / roi_back 约束一致性的自动检查。

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Intent for #1846 · codex · gpt56 · 10.1 AIC · ⌖ 2.94 AIC · ⊞ 12.1K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant