Repository navigation
Conversation
Both while True loops in switch_role could spin indefinitely. When the game is left on a sub-page of the onmyoji screen (e.g. the hero-exchange page), I_ONMYOJI_SWITCH never opens the role list, so the loop kept clicking until the global ~2min GameStuckError watchdog fired, losing the actual cause. Each loop now raises a ScriptError naming the failure after 20s.
feat(TouchFish):修复摸鱼行动逻辑问题
fix(SwitchOnmyoji): give both switch_role loops a bounded exit
- 新增click_random_buff,4个buff槽位随机点击其一 - hero1_skill_wait/hero2_skill_wait未命中目标buff时调用兜底后再点确认
fix(FrogBoss):修复对弈竞猜相关资源,激活oas策略客制化权重。
fix(HeroTest): 祝福识别超时后随机选择,避免秘境卡住
There was a problem hiding this comment.
嘿——我已经审查了你的更改,整体看起来很棒!
Sourcery 评估
需要人工审查。 新的 OAS 策略可以自动选择并提交游戏内下注,因此错误的预测、过时的 UI 比赛信息或不正确的记录关联都可能消耗账户中的金币;此外,外部预测服务还引入了新的运行时依赖。回滚可以防止未来继续下注,但无法追回已经花费的货币。
Original comment in English
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The new OAS strategy can automatically select and submit an in-game bet, so a bad prediction, stale UI match, or incorrect record association could spend the account's gold; the external prediction service also adds a new runtime dependency. Reverting prevents future bets but cannot recover currency already spent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 摘要
提升游戏任务的可靠性,并通过结果验证和持久化策略支持扩展 Frog Boss 自动化功能。
新功能:
错误修复:
改进:
测试:
杂项:
Original summary in English
Summary by Sourcery
Improve game task reliability and extend Frog Boss automation with outcome-verified, persistent strategy support.
New Features:
Bug Fixes:
Enhancements:
Tests:
Chores: