Skip to content

Master to dev - #1889

Merged
runhey merged 13 commits into
devfrom
master
Oct 9, 2026
Merged

runhey merged 13 commits into
devfrom
master

Conversation

@runhey

@runhey runhey commented Oct 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

runhey and others added 13 commits September 9, 2026 21:58
Automated PR 2026.09.11
Automated PR 2026.09.25
Automated PR 2026.10.02
修复 default_pages.py 调用不存在的函数导致的 ImportError
Fixes #1884
- 删除函数内部冗余的自我导入
- 用 try/except 兼容 DemonEncounter 等没有 direct general_battle_config 的任务
- 修复 CodeRabbit review comments
Automated PR 2026.10.09
…eral-battle

fix: add missing run_task_or_default_general_battle function (#1884)
@sourcery-ai

sourcery-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Sorry @runhey, your pull request is larger than the review limit of 150,000 diff characters

@runhey
runhey merged commit ff594d1 into dev Oct 9, 2026
5 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Findings

  • C1 [风险]
    位置:PR 全部变更,重点为 .github/workflows/*、.github/workflows/shared/engine.md、tasks/Component/GeneralBattle/general_battle.py:716
    原因:同一 PR 同时升级 gh-aw 运行材料、修改模型配置并新增通用战斗兜底逻辑,超出单一“Master to dev”同步意图,回归范围较大。
    修改:拆分为运行材料升级、模型配置和业务代码三个 PR,或在 PR 描述中明确各部分的独立目的及验证范围。
  • C4 [风险]
    位置:tasks/Component/GeneralBattle/general_battle.py:716-728,run_task_or_default_general_battle
    原因:新增兜底函数覆盖了缺少 general_battle_config 的分支,但未见针对正常配置、缺失配置及 run_general_battle 失败路径的自动化测试。
    修改:补充单元测试,至少覆盖属性缺失返回 False、正常配置执行及战斗执行异常/失败时的结果。

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Checklist for #1889 · codex · gpt56 · 26.5 AIC · ⌖ 2.59 AIC · ⊞ 12.1K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants