Repository navigation
fix: 补充修复组队邀请UI状态识别问题 (#1881) - #1924
allesgutefy wants to merge 3 commits into
Conversation
- Update gi_i_default.png, gi_i_no_default.png, gi_gi_sure.png, gi_cancel.png for new UI - Add interval=3 for I_GI_SURE (I_I_NO_DEFAULT was already in previous merged PR) - Fix runhey#1881
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿——我发现了 1 个问题
给 AI Agent 的提示
请处理本次代码审查中的评论：
## 个别评论
### 评论 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**Bondling 邀请卡住**
当 Bondling Fairyland 的队长或成员处理更新后的邀请确认对话框时，Bondling Fairyland 的 `check_and_invite` 和 `check_then_accept` 重写方法仍以 `interval=1` 点击 `I_GI_SURE`，因此确认对话框会保持打开状态，邀请流程也会一直卡住。
请将 Bondling Fairyland 的这两个重写方法都更新为以 `interval=3` 点击 `I_GI_SURE`。
另外还需修改 `tasks/Component/GeneralInvite/general_invite.py:575`。
</issue_to_address>Sourcery 评估
等待批准。 请先处理 1 个发现的问题。
阻塞性发现：tasks/Component/GeneralInvite/general_invite.py:552
Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**Bondling invitations stay stuck**
When a Bondling Fairyland leader or member handles the updated invitation confirmation dialog, bondling Fairyland’s `check_and_invite` and `check_then_accept` overrides still click `I_GI_SURE` with `interval=1`, so the confirmation dialog stays open and invite flows remain stuck.
Update both Bondling Fairyland overrides to click `I_GI_SURE` with `interval=3`.
Also at `tasks/Component/GeneralInvite/general_invite.py:575`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tasks/Component/GeneralInvite/general_invite.py:552
- Add I_I_NO_DEFAULT interval=3 (fix incomplete fix from PR runhey#1886) - Add I_GI_SURE interval=3 - Update 4 GI assets for Oct 10 game UI update - PR runhey#1886 was only merged to master, not dev, so repeat changes here Fixes runhey#1881
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthroughcheck_and_invite 中切换邀请选项和点击确认按钮的间隔从 1 秒改为 3 秒。check_then_accept 中点击确认按钮的间隔也从 1 秒改为 3 秒。现有循环条件未变。 关联问题评估
问题严重性 <fixed_issue_severity>Medium</fixed_issue_severity> Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The invitation flow’s retry timing changes as intended, and no specific behavior that would block merging is established. ✨ Finishing Touches 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 兔子敲下确认键，间隔慢慢变长， Comment |
PR #1924 更新说明问题背景PR #1886 合并到 master 后，经本地实测发现修复不完整：
另外，PR #1886 未合并到 dev 分支。 修复内容
本地验证
请审核。 Fixes #1881 |
1 participant
Issue #1881 补充修复
问题背景
Issue #1881 的修复（PR #1886）合并后，经本地实测发现：
I_I_NO_DEFAULT → interval=3（原 PR 的修改）仍无法解决问题I_GI_SURE → interval=3后问题解决修复内容
代码修改：
I_GI_SURE的appear_then_click改为interval=3I_I_NO_DEFAULT的修改已在 PR fix: 修复组队邀请默认勾选框点击后UI状态识别问题 (#1881) #1886 合入）素材更新：更新4张游戏UI素材，适配10月10日游戏更新后的新界面：
gi_i_default.png（已勾选状态）gi_i_no_default.png（未勾选状态）gi_gi_sure.png（确定按钮）gi_cancel.png（取消按钮）本地验证
I_GI_SURE interval=3：勾选框循环正常，但点击确认按钮后弹窗无法关闭I_GI_SURE interval=3后：流程正常，组队邀请功能完全恢复Fixes #1881
Sourcery 总结
错误修复：
Original summary in English
Sourcery 总结
错误修复：
Original summary in English
Sourcery 摘要
错误修复：
Original summary in English
Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit