Repository navigation
fix: 补充修复组队邀请UI状态识别问题 (#1881) - #1925
allesgutefy wants to merge 1 commit into
Conversation
- Add I_I_NO_DEFAULT interval=3 (remove sleep(0.8)) - Add I_GI_SURE interval=3 in check_and_invite - Update 4 GI assets for new UI - Fixes runhey#1881
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
您好——我发现了 1 个问题
面向 AI Agent 的提示
请处理本次代码审查中的评论：
## 单独评论
### 评论 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**确认对话框仍处于打开状态**
当 Bondling Fairyland 的首领到达受影响的邀请确认弹窗时，`BondlingFairyland.ScriptTask` 会将 `check_and_invite` 解析为其自身的 `GeneralInvite` 覆盖实现，其中 `I_I_NO_DEFAULT` 和 `I_GI_SURE` 仍以 `interval=1` 的间隔点击；旧的重试行为会使确认对话框保持打开状态。
请更新 Bondling Fairyland 的覆盖实现，使这两个点击都使用更长的重试间隔。
</issue_to_address>Sourcery 评估
等待批准。 请先处理 1 个发现的问题。
阻塞性发现：tasks/Component/GeneralInvite/general_invite.py:552
Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**Confirmation dialog remains open**
When a Bondling Fairyland leader reaches the affected invitation confirmation popup, `BondlingFairyland.ScriptTask` resolves `check_and_invite` to its own `GeneralInvite` override, where `I_I_NO_DEFAULT` and `I_GI_SURE` are still clicked with `interval=1`; the old retry behavior leaves the confirmation dialog open.
Update the Bondling Fairyland override to use the longer retry interval for both clicks.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tasks/Component/GeneralInvite/general_invite.py:552
| if not self.appear(self.I_GI_SURE): | ||
| break | ||
| if self.appear_then_click(self.I_GI_SURE, interval=1): | ||
| if self.appear_then_click(self.I_GI_SURE, interval=3): |
There was a problem hiding this comment.
🟠 高优先级 · 确认对话框仍处于打开状态
当 Bondling Fairyland 的首领到达受影响的邀请确认弹窗时，BondlingFairyland.ScriptTask 会将 check_and_invite 解析为其自身的 GeneralInvite 覆盖实现，其中 I_I_NO_DEFAULT 和 I_GI_SURE 仍以 interval=1 的间隔点击；旧的重试行为会使确认对话框保持打开状态。
请更新 Bondling Fairyland 的覆盖实现，使这两个点击都使用更长的重试间隔。
面向 AI Agent 的提示
在 `tasks/Component/GeneralInvite/general_invite.py` 第 552 行：
**确认对话框仍处于打开状态**
当 Bondling Fairyland 的首领到达受影响的邀请确认弹窗时，`BondlingFairyland.ScriptTask` 会将 `check_and_invite` 解析为其自身的 `GeneralInvite` 覆盖实现，其中 `I_I_NO_DEFAULT` 和 `I_GI_SURE` 仍以 `interval=1` 的间隔点击；旧的重试行为会使确认对话框保持打开状态。
请更新 Bondling Fairyland 的覆盖实现，使这两个点击都使用更长的重试间隔。Original comment in English
🟠 High · Confirmation dialog remains open
When a Bondling Fairyland leader reaches the affected invitation confirmation popup, BondlingFairyland.ScriptTask resolves check_and_invite to its own GeneralInvite override, where I_I_NO_DEFAULT and I_GI_SURE are still clicked with interval=1; the old retry behavior leaves the confirmation dialog open.
Update the Bondling Fairyland override to use the longer retry interval for both clicks.
Prompt for AI agents
In `tasks/Component/GeneralInvite/general_invite.py` at line 552:
**Confirmation dialog remains open**
When a Bondling Fairyland leader reaches the affected invitation confirmation popup, `BondlingFairyland.ScriptTask` resolves `check_and_invite` to its own `GeneralInvite` override, where `I_I_NO_DEFAULT` and `I_GI_SURE` are still clicked with `interval=1`; the old retry behavior leaves the confirmation dialog open.
Update the Bondling Fairyland override to use the longer retry interval for both clicks.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough
关联问题评估
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The invite flow uses a longer retry interval; available evidence does not establish a concrete merge-blocking failure. ✨ Finishing Touches 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 我是小兔，蹦过邀请按钮旁， Comment |
|
84eda19 确认一下这个，你是master |
|
不过确实勾选框没更 |
2 participants
Issue #1881 补充修复
问题背景
PR #1886 合入 master 后，经本地实测发现：
I_I_NO_DEFAULT → interval=3仍无法解决组队邀请确认弹窗无法关闭的问题I_GI_SURE → interval=3后问题解决另外，PR #1886 未合入 dev 分支。
修复内容
代码修改（仅队长端
check_and_invite函数）：I_I_NO_DEFAULT的appear_then_click改为interval=3I_GI_SURE的appear_then_click改为interval=3check_then_accept不需修改素材更新：适配10月10日游戏UI更新
gi_i_default.png（已勾选状态）gi_i_no_default.png（未勾选状态）gi_gi_sure.png（确定按钮）gi_cancel.png（取消按钮）本地验证
I_GI_SURE interval=3：点击确认按钮后弹窗无法关闭I_GI_SURE interval=3后：流程正常Fixes #1881
Summary by Sourcery
修复组队邀请流程中队长端弹窗状态识别和关闭异常。
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
修复组队邀请流程中队长端弹窗状态识别和关闭异常。
Bug Fixes:
Enhancements:
Summary by CodeRabbit