Repository navigation
fix: 补充修复组队邀请UI状态识别问题 (#1881) - #1928
allesgutefy wants to merge 1 commit into
Conversation
- I_I_NO_DEFAULT interval=3 in check_and_invite - I_GI_SURE interval=3 in check_and_invite - Update 4 GI assets for new UI - Fixes runhey#1881
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
你好——我发现了 1 个问题
给 AI 代理的提示
请处理本次代码审查中的评论：
## 个别评论
### 评论 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**Bondling 邀请确认仍然会卡住**
当队长运行 Bondling Fairyland 并在战斗结束后看到邀请确认弹窗时，`tasks/BondlingFairyland/general_invite.py` 定义了自己的 `check_and_invite`，因此 Bondling Fairyland 的队长会绕过这次更新后的实现，继续以 `interval=1` 的间隔点击 `I_GI_SURE`；更新后的确认提示仍会保持打开状态，导致队长卡住。
请将相同的间隔修改应用到 Bondling Fairyland 的 `check_and_invite` 覆盖实现中，或者让它使用更新后的共享实现。
</issue_to_address>Sourcery 评估
等待批准。 需要先处理 1 个发现的问题。
阻塞性发现：tasks/Component/GeneralInvite/general_invite.py:552
Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tasks/Component/GeneralInvite/general_invite.py" line_range="552" />
<code_context>
if not self.appear(self.I_GI_SURE):
break
- if self.appear_then_click(self.I_GI_SURE, interval=1):
+ if self.appear_then_click(self.I_GI_SURE, interval=3):
continue
</code_context>
<issue_to_address>
**Bondling invite confirmation still hangs**
When a leader runs Bondling Fairyland and gets the post-battle invite confirmation popup, `tasks/BondlingFairyland/general_invite.py` defines its own `check_and_invite`, so Bondling Fairyland leaders bypass this updated implementation and continue clicking `I_GI_SURE` at `interval=1`; the updated confirmation prompt remains open and the leader gets stuck.
Apply the same interval changes to the Bondling Fairyland `check_and_invite` override, or make it use the updated shared implementation.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tasks/Component/GeneralInvite/general_invite.py:552
| if not self.appear(self.I_GI_SURE): | ||
| break | ||
| if self.appear_then_click(self.I_GI_SURE, interval=1): | ||
| if self.appear_then_click(self.I_GI_SURE, interval=3): |
There was a problem hiding this comment.
🟡 中等 · Bondling 邀请确认仍然会卡住
当队长运行 Bondling Fairyland 并在战斗结束后看到邀请确认弹窗时，tasks/BondlingFairyland/general_invite.py 定义了自己的 check_and_invite，因此 Bondling Fairyland 的队长会绕过这次更新后的实现，继续以 interval=1 的间隔点击 I_GI_SURE；更新后的确认提示仍会保持打开状态，导致队长卡住。
请将相同的间隔修改应用到 Bondling Fairyland 的 check_and_invite 覆盖实现中，或者让它使用更新后的共享实现。
给 AI 代理的提示
在 `tasks/Component/GeneralInvite/general_invite.py` 的第 552 行：
**Bondling 邀请确认仍然会卡住**
当队长运行 Bondling Fairyland 并在战斗结束后看到邀请确认弹窗时，`tasks/BondlingFairyland/general_invite.py` 定义了自己的 `check_and_invite`，因此 Bondling Fairyland 的队长会绕过这次更新后的实现，继续以 `interval=1` 的间隔点击 `I_GI_SURE`；更新后的确认提示仍会保持打开状态，导致队长卡住。
请将相同的间隔修改应用到 Bondling Fairyland 的 `check_and_invite` 覆盖实现中，或者让它使用更新后的共享实现。Original comment in English
🟡 Medium · Bondling invite confirmation still hangs
When a leader runs Bondling Fairyland and gets the post-battle invite confirmation popup, tasks/BondlingFairyland/general_invite.py defines its own check_and_invite, so Bondling Fairyland leaders bypass this updated implementation and continue clicking I_GI_SURE at interval=1; the updated confirmation prompt remains open and the leader gets stuck.
Apply the same interval changes to the Bondling Fairyland check_and_invite override, or make it use the updated shared implementation.
Prompt for AI agents
In `tasks/Component/GeneralInvite/general_invite.py` at line 552:
**Bondling invite confirmation still hangs**
When a leader runs Bondling Fairyland and gets the post-battle invite confirmation popup, `tasks/BondlingFairyland/general_invite.py` defines its own `check_and_invite`, so Bondling Fairyland leaders bypass this updated implementation and continue clicking `I_GI_SURE` at `interval=1`; the updated confirmation prompt remains open and the leader gets stuck.
Apply the same interval changes to the Bondling Fairyland `check_and_invite` override, or make it use the updated shared implementation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthroughcheck_and_invite 中，点击 I_I_NO_DEFAULT 和 I_GI_SURE 的间隔从 1 秒改为 3 秒。判断条件和循环流程未变。
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Users may wait longer between the two invitation clicks. Available evidence indicates the button-disappearance check remains immediate, and no concrete merge-blocking behavior is identified. ✨ Finishing Touches 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 兔子轻点邀请框， Comment |
1 participant
Issue #1881 补充修复
问题背景
PR #1886 合入 master 后，经本地实测发现：
I_I_NO_DEFAULT → interval=3仍无法解决组队邀请确认弹窗无法关闭的问题I_GI_SURE → interval=3后问题解决另外，PR #1886 未合入 dev 分支。
修复内容
代码修改（仅队长端
check_and_invite函数）：I_I_NO_DEFAULT的appear_then_click改为interval=3I_GI_SURE的appear_then_click改为interval=3check_then_accept不需修改素材更新：适配10月10日游戏UI更新
gi_i_default.png（已勾选状态）gi_i_no_default.png（未勾选状态）gi_gi_sure.png（确定按钮）gi_cancel.png（取消按钮）本地验证
I_GI_SURE interval=3：点击确认按钮后弹窗无法关闭I_GI_SURE interval=3后：流程正常Fixes #1881
Sourcery 总结
改进团队邀请对话框的处理，以便在游戏界面更新后可靠地完成队长端的邀请流程。
错误修复：
Original summary in English
Summary by Sourcery
Improve team invitation dialog handling to reliably complete the leader-side invitation flow after the game UI update.
Bug Fixes:
Summary by CodeRabbit