Repository navigation
feat(execute): adding sendStdIn to devbox exec - #647
Merged
Merged
Conversation
Contributor
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Contributor
|
CodeAnt AI finished reviewing your PR. |
✅ Object Smoke Tests & Coverage ReportTest Results✅ All smoke tests passed Coverage Results
Coverage Requirement: 100% function coverage (all public methods must be called in smoke tests) ✅ All tests passed and all object methods are covered! View detailed coverage reportCoverage reports are available in the workflow artifacts. Lines/branches/statements coverage is tracked but not required to be 100%. |
wall-rl
approved these changes
Nov 12, 2025
stainless-app
Bot
force-pushed
the
next
branch
8 times, most recently
from
February 5, 2026 20:42
f6ec4e2 to
86d8126
Compare
stainless-app
Bot
force-pushed
the
next
branch
4 times, most recently
from
February 25, 2026 21:42
5542b72 to
c67ce2c
Compare
stainless-app
Bot
force-pushed
the
next
branch
2 times, most recently
from
March 10, 2026 03:50
1a4be5a to
63a8d33
Compare
stainless-app
Bot
force-pushed
the
next
branch
8 times, most recently
from
March 25, 2026 00:51
88863c6 to
54b8b74
Compare
stainless-app
Bot
force-pushed
the
next
branch
6 times, most recently
from
April 7, 2026 18:17
38551a5 to
eedbc55
Compare
stainless-app
Bot
force-pushed
the
next
branch
5 times, most recently
from
July 10, 2026 23:40
3444fe4 to
c238123
Compare
tode-rl
requested changes
Sep 24, 2026
tode-rl
left a comment
tode-rl
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes. Reviewed 277df1e in full mode. See inline comments for details.
Collaborator
|
Review check: reviewed |
next moved src/objects/execution.ts to src/sdk/execution.ts; carry the sendStdIn change into the new file. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- closeStdIn() sends the EOF signal so stdin-consuming commands can exit
normally; the smoke test now completes `cat` via EOF instead of kill.
- sendStdIn()/closeStdIn() throw RunloopError when the API reports
success: false.
- Post to send_std_in directly: the generated executions.sendStdIn()
treats a `{ signal: 'EOF' }` body as RequestOptions and drops it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
❌ Object Smoke Tests FailedTest Results❌ Some smoke tests failed Please fix the failing tests before checking coverage. |
execAsync returns before the execution starts, so status can still be queued. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tode-rl
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds send std in to devbox exec.
Testing
Breaking Changes
Checklist
feat:orfeat(scope):)