Skip to content

Add CPTR_EL2 fields for HCR_EL2.E2H==0 - #84

Merged
berkus merged 1 commit into
mainfrom
add-cptr-el2-fields
Oct 8, 2026
Merged

berkus merged 1 commit into
mainfrom
add-cptr-el2-fields

Conversation

@berkus

@berkus berkus commented Oct 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@berkus
berkus requested a balanced review from Copilot October 7, 2026 22:08
@berkus berkus self-assigned this Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a non-blocking documentation correction remains.

1 open finding
What changed in this PR

Extends the AArch64 register API with CPTR_EL2 fields for HCR_EL2.E2H == 0.

Changes:

  • Adds trap-control and reserved-one fields.
  • Documents the layout scope, trap behavior, and feature dependencies.
File Description
packages/​aarch64-cpu/​src/​registers/​cptr_el2.rs Adds non-E2H field definitions and documentation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/aarch64-cpu/src/registers/cptr_el2.rs
@berkus
berkus force-pushed the add-cptr-el2-fields branch from e1189df to 5acd2c3 Compare October 8, 2026 20:42
@berkus
berkus merged commit 3453cf9 into main Oct 8, 2026
48 checks passed
@berkus
berkus deleted the add-cptr-el2-fields branch October 8, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants