Skip to content

cloudfront: Support cache-tag invalidations - #14229

Merged
Turbo87 merged 2 commits into
rust-lang:mainfrom
Turbo87:cloudfront-cache-tags
Jul 15, 2026
Merged

cloudfront: Support cache-tag invalidations#14229
Turbo87 merged 2 commits into
rust-lang:mainfrom
Turbo87:cloudfront-cache-tags

Conversation

@Turbo87

@Turbo87 Turbo87 commented Jul 14, 2026

Copy link
Copy Markdown
Member

CloudFront represents cache-tag invalidations as entries beginning with #. Prefixing those entries with / changes them into path invalidations and prevents the requested tag purge.

This PR changes the implementation to preserve both / paths and # tags during normalization, and cover
mixed invalidation requests.

@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Jul 14, 2026
@Turbo87
Turbo87 requested a review from a team July 14, 2026 06:21
Comment thread src/cloudfront.rs Outdated
Turbo87 added 2 commits July 15, 2026 21:38
CloudFront invalidation requests currently normalize paths inline by
adding a leading slash. Cache-tag invalidations use a leading `#`, so the
current behavior must be locked down before extending it.

Extract the normalization logic and cover existing slash insertion and
preservation behavior without changing production results.
CloudFront represents cache-tag invalidations as entries beginning with
`#`. Prefixing those entries with `/` changes them into path invalidations
and prevents the requested tag purge.

Preserve both `/` paths and `#` tags during normalization, and cover a
mixed invalidation request.
@Turbo87
Turbo87 force-pushed the cloudfront-cache-tags branch from e64d732 to e1a9fd3 Compare July 15, 2026 19:39
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Turbo87
Turbo87 merged commit 319744c into rust-lang:main Jul 15, 2026
12 checks passed
@Turbo87
Turbo87 deleted the cloudfront-cache-tags branch July 15, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants