Skip to content

Consistently order rev dep version info - #14246

Merged
Turbo87 merged 1 commit into
rust-lang:mainfrom
carols10cents:order-rev-dep-versions-for-snapshot
Jul 16, 2026
Merged

Consistently order rev dep version info#14246
Turbo87 merged 1 commit into
rust-lang:mainfrom
carols10cents:order-rev-dep-versions-for-snapshot

Conversation

@carols10cents

@carols10cents carols10cents commented Jul 15, 2026

Copy link
Copy Markdown
Member

Otherwise, postgres doesn't guarantee any order and the test asserting this snapshot can be flaky.

I have a branch locally that changes the schema and somehow changes the undefined order that this snapshot's data gets returned 🤷🏻‍♀️ it fails consistently without this change and passes consistently with the change.

The versions get associated with the dependencies in the UI based on version ID, so changing the order doesn't change any user-visible behavior.

Otherwise, postgres doesn't guarantee any order and the test asserting
this snapshot can be flaky.

@Turbo87 Turbo87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Turbo87 Turbo87 changed the title Consistenly order rev dep version info Consistently order rev dep version info Jul 16, 2026
@Turbo87
Turbo87 merged commit b4f063d into rust-lang:main Jul 16, 2026
12 checks passed
@carols10cents
carols10cents deleted the order-rev-dep-versions-for-snapshot branch July 16, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants