test(ref_binding_to_reference): enable autofix (#17371)

Multi-span suggestions work now! Unlike the lint, unfortunately -- see
#17370.

changelog: none

Author: samueltardieu

tests/ui/ref_binding_to_reference.fixed

@@ -0,0 +1,99 @@
+#![warn(clippy::ref_binding_to_reference)]
+#![expect(clippy::explicit_auto_deref)]
+#![allow(clippy::needless_borrowed_reference)]
+
+fn f1(_: &str) {}
+macro_rules! m2 {
+    ($e:expr) => {
+        f1(*$e)
+    };
+}
+macro_rules! m3 {
+    ($i:ident) => {
+        Some(ref $i)
+    };
+}
+
+fn main() {
+    let x = String::new();
+
+    // Ok, the pattern is from a macro
+    let _: &&String = match Some(&x) {
+        m3!(x) => x,
+        None => return,
+    };
+
+    // Err, reference to a &String
+    #[expect(
+        clippy::ref_binding_to_reference,
+        reason = "The suggestion doesn't compile, see https://github.com/rust-lang/rust-clippy/issues/17370"
+    )]
+    let _: &&String = match Some(&x) {
+        Some(ref x) => x,
+        None => return,
+    };
+
+    // Err, reference to a &String
+    #[expect(
+        clippy::ref_binding_to_reference,
+        reason = "The suggestion doesn't compile, see https://github.com/rust-lang/rust-clippy/issues/17370"
+    )]
+    let _: &&String = match Some(&x) {
+        Some(ref x) => {
+            f1(x);
+            f1(*x);
+            x
+        },
+        None => return,
+    };
+
+    // Err, reference to a &String
+    match Some(&x) {
+        Some(x) => m2!(&x),
+        //~^ ref_binding_to_reference
+        None => return,
+    }
+
+    // Err, reference to a &String
+    let _ = |&x: &&String| {
+        //~^ ref_binding_to_reference
+
+        let _: &&String = &x;
+    };
+}
+
+// Err, reference to a &String
+fn f2<'a>(&x: &&'a String) -> &'a String {
+    //~^ ref_binding_to_reference
+
+    let _: &&String = &x;
+    x
+}
+
+trait T1 {
+    // Err, reference to a &String
+    fn f(&x: &&String) {
+        //~^ ref_binding_to_reference
+
+        let _: &&String = &x;
+    }
+}
+
+struct S;
+impl T1 for S {
+    // Err, reference to a &String
+    fn f(&x: &&String) {
+        //~^ ref_binding_to_reference
+
+        let _: &&String = &x;
+    }
+}
+
+fn check_expect_suppression() {
+    let x = String::new();
+    #[expect(clippy::ref_binding_to_reference)]
+    let _: &&String = match Some(&x) {
+        Some(ref x) => x,
+        None => return,
+    };
+}

tests/ui/ref_binding_to_reference.rs

@@ -1,7 +1,6 @@
-// FIXME: run-rustfix waiting on multi-span suggestions
-//@no-rustfix
 #![warn(clippy::ref_binding_to_reference)]
-#![expect(clippy::explicit_auto_deref, clippy::needless_borrowed_reference)]
+#![expect(clippy::explicit_auto_deref)]
+#![allow(clippy::needless_borrowed_reference)]
 
 fn f1(_: &str) {}
 macro_rules! m2 {
@@ -25,17 +24,22 @@ fn main() {
     };
 
     // Err, reference to a &String
+    #[expect(
+        clippy::ref_binding_to_reference,
+        reason = "The suggestion doesn't compile, see https://github.com/rust-lang/rust-clippy/issues/17370"
+    )]
     let _: &&String = match Some(&x) {
         Some(ref x) => x,
-        //~^ ref_binding_to_reference
         None => return,
     };
 
     // Err, reference to a &String
+    #[expect(
+        clippy::ref_binding_to_reference,
+        reason = "The suggestion doesn't compile, see https://github.com/rust-lang/rust-clippy/issues/17370"
+    )]
     let _: &&String = match Some(&x) {
         Some(ref x) => {
-            //~^ ref_binding_to_reference
-
             f1(x);
             f1(*x);
             x

tests/ui/ref_binding_to_reference.stderr

@@ -1,47 +1,19 @@
 error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:29:14
+  --> tests/ui/ref_binding_to_reference.rs:52:14
    |
-LL |         Some(ref x) => x,
+LL |         Some(ref x) => m2!(x),
    |              ^^^^^
    |
    = note: `-D clippy::ref-binding-to-reference` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ref_binding_to_reference)]`
 help: try
    |
-LL -         Some(ref x) => x,
-LL +         Some(x) => &x,
-   |
-
-error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:36:14
-   |
-LL |         Some(ref x) => {
-   |              ^^^^^
-   |
-help: try
-   |
-LL ~         Some(x) => {
-LL |
-LL |
-LL |             f1(x);
-LL ~             f1(x);
-LL ~             &x
-   |
-
-error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:48:14
-   |
-LL |         Some(ref x) => m2!(x),
-   |              ^^^^^
-   |
-help: try
-   |
 LL -         Some(ref x) => m2!(x),
 LL +         Some(x) => m2!(&x),
    |
 
 error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:54:15
+  --> tests/ui/ref_binding_to_reference.rs:58:15
    |
 LL |     let _ = |&ref x: &&String| {
    |               ^^^^^
@@ -55,7 +27,7 @@ LL ~         let _: &&String = &x;
    |
 
 error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:62:12
+  --> tests/ui/ref_binding_to_reference.rs:66:12
    |
 LL | fn f2<'a>(&ref x: &&'a String) -> &'a String {
    |            ^^^^^
@@ -70,7 +42,7 @@ LL ~     x
    |
 
 error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:71:11
+  --> tests/ui/ref_binding_to_reference.rs:75:11
    |
 LL |     fn f(&ref x: &&String) {
    |           ^^^^^
@@ -84,7 +56,7 @@ LL ~         let _: &&String = &x;
    |
 
 error: this pattern creates a reference to a reference
-  --> tests/ui/ref_binding_to_reference.rs:81:11
+  --> tests/ui/ref_binding_to_reference.rs:85:11
    |
 LL |     fn f(&ref x: &&String) {
    |           ^^^^^
@@ -97,5 +69,5 @@ LL |
 LL ~         let _: &&String = &x;
    |
 
-error: aborting due to 7 previous errors
+error: aborting due to 5 previous errors