chore: kebab-case names for binaries (#17639)

These commits follow the lint `cargo::non_kebab_case_bins`

https://doc.rust-lang.org/nightly/cargo/reference/lints.html#non_kebab_case_bins

The failure was found in
<rust-lang/rust#161789 (comment)>
when syncing Cargo submodule.

* `clippy_dev` `package.name` got renamed to `clippy-dev`.
* Expect no actual developer workflow changes as people usually run
`cargo dev` via `.cargo/config.toml` alias.
* ‼️ One caveat of this is that the next subtree sync need to also
update the name in rust-lang/rust's Cargo.lock
* `clippy_dummy`, because it is published already, rename its bin name
directly as `clippy`. This is a dummy package so it doesn't matter that
much, as we are unlikely to publish new versions.
* Test snapshots and test binary names are also converted to dashes.
They are less controversial than above as being completely internal.

changelog: none

Author: flip1995

.cargo/config.toml

@@ -2,7 +2,7 @@
 bless = "test --config env.RUSTC_BLESS='1'"
 uitest = "test --test compile-test"
 uibless = "bless --test compile-test"
-dev = "run --package clippy_dev --bin clippy_dev --manifest-path clippy_dev/Cargo.toml --"
+dev = "run --package clippy-dev --bin clippy-dev --manifest-path clippy_dev/Cargo.toml --"
 lintcheck = "run --package lintcheck --bin lintcheck --manifest-path lintcheck/Cargo.toml  -- "
 collect-metadata = "test --test compile-test --config env.COLLECT_METADATA='1'"
 
@@ -19,7 +19,7 @@ profile-rustflags = true
 split-debuginfo = "unpacked"
 
 # Add back the containing directory of the packages we have to refer to using --manifest-path
-[profile.dev.package.clippy_dev]
+[profile.dev.package.clippy-dev]
 rustflags = ["--remap-path-prefix", "=clippy_dev"]
 [profile.dev.package.lintcheck]
 rustflags = ["--remap-path-prefix", "=lintcheck"]

.github/workflows/clippy_mq.yml

@@ -79,7 +79,7 @@ jobs:
       run: cargo test
       working-directory: rustc_tools_util
 
-    - name: Test clippy_dev
+    - name: Test clippy-dev
       run: cargo test
       working-directory: clippy_dev
 

.github/workflows/clippy_pr.yml

@@ -53,7 +53,7 @@ jobs:
       run: cargo test
       working-directory: rustc_tools_util
 
-    - name: Test clippy_dev
+    - name: Test clippy-dev
       run: cargo test
       working-directory: clippy_dev
 

CONTRIBUTING.md

@@ -1,5 +1,5 @@
 [package]
-name = "clippy_dev"
+name = "clippy-dev"
 description = "Clippy developer tooling"
 version = "0.0.1"
 edition = "2024"

clippy_dev/Cargo.toml

@@ -3,7 +3,7 @@ use std::path::Path;
 
 /// Rusts setup uses `git rev-parse --git-common-dir` to get the root directory of the repo.
 /// I've decided against this for the sake of simplicity and to make sure that it doesn't install
-/// the hook if `clippy_dev` would be used in the rust tree. The hook also references this tool
+/// the hook if `clippy-dev` would be used in the rust tree. The hook also references this tool
 /// for formatting and should therefore only be used in a normal clone of clippy
 const REPO_GIT_DIR: &str = ".git";
 const HOOK_SOURCE_FILE: &str = "util/etc/pre-commit.sh";
@@ -36,7 +36,7 @@ fn check_precondition(force_override: bool) -> bool {
     // Make sure that we can find the git repository
     let git_path = Path::new(REPO_GIT_DIR);
     if !git_path.exists() || !git_path.is_dir() {
-        eprintln!("error: clippy_dev was unable to find the `.git` directory");
+        eprintln!("error: clippy-dev was unable to find the `.git` directory");
         return false;
     }
 

clippy_dev/src/setup/git_hook.rs

@@ -96,7 +96,7 @@ fn inject_deps_into_project(rustc_source_dir: &Path, project: &ClippyProjectInfo
     }
 }
 
-/// `clippy_dev` expects to be executed in the root directory of Clippy. This function
+/// `clippy-dev` expects to be executed in the root directory of Clippy. This function
 /// loads the given file or returns an error. Having it in this extra function ensures
 /// that the error message looks nice.
 fn read_project_file(file_path: &str) -> Result<String, ()> {

clippy_dev/src/setup/intellij.rs

@@ -12,5 +12,9 @@ license = "MIT OR Apache-2.0"
 keywords = ["clippy", "lint", "plugin"]
 categories = ["development-tools", "development-tools::cargo-plugins"]
 
+[[bin]]
+name = "clippy"
+path = "src/main.rs"
+
 [build-dependencies]
 term = "1"

clippy_dummy/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "clippy_test_deps"
+name = "clippy-test-deps"
 version = "0.1.0"
 edition = "2021"