Call in_external_macro after running other checks in various places (#17294)

This is the fist batch of delayed calls. Not all of the changed
locations are ideal, but changing something like the `matches` pass any
further would be a lot more involved.

changelog: none

Author: dswij

clippy_lints/src/attrs/allow_attributes.rs

@@ -8,9 +8,9 @@ use rustc_lint::{EarlyContext, LintContext as _};
 
 // Separate each crate's features.
 pub fn check<'cx>(cx: &EarlyContext<'cx>, attr: &'cx Attribute) {
-    if !attr.span.in_external_macro(cx.sess().source_map())
-        && let AttrStyle::Outer = attr.style
+    if let AttrStyle::Outer = attr.style
         && let Some(path_span) = attr.path_span()
+        && !attr.span.in_external_macro(cx.sess().source_map())
         && !is_from_proc_macro(cx, attr)
     {
         #[expect(clippy::collapsible_span_lint_calls, reason = "rust-clippy#7797")]

clippy_lints/src/attrs/useless_attribute.rs

@@ -11,9 +11,6 @@ pub(super) fn check(cx: &EarlyContext<'_>, item: &Item, attrs: &[Attribute]) {
     let skip_unused_imports = attrs.iter().any(|attr| attr.has_name(sym::macro_use));
 
     for attr in attrs {
-        if attr.span.in_external_macro(cx.sess().source_map()) {
-            return;
-        }
         if let Some(lint_list) = &attr.meta_item_list()
             && attr.name().is_some_and(is_lint_level)
         {
@@ -72,9 +69,10 @@ pub(super) fn check(cx: &EarlyContext<'_>, item: &Item, attrs: &[Attribute]) {
                     _ => {},
                 }
             }
-            let line_span = first_line_of_span(cx, attr.span);
 
-            if let Some(src) = line_span.get_text(cx)
+            if !attr.span.in_external_macro(cx.sess().source_map())
+                && let line_span = first_line_of_span(cx, attr.span)
+                && let Some(src) = line_span.get_text(cx)
                 && src.contains("#[")
             {
                 #[expect(clippy::collapsible_span_lint_calls)]

clippy_lints/src/blocks_in_conditions.rs

@@ -3,7 +3,7 @@ use clippy_utils::source::snippet_block_with_applicability;
 use clippy_utils::{contains_return, higher, is_from_proc_macro, leaks_droppable_temporary};
 use rustc_errors::Applicability;
 use rustc_hir::{BlockCheckMode, Expr, ExprKind, MatchSource};
-use rustc_lint::{LateContext, LateLintPass, LintContext as _};
+use rustc_lint::{LateContext, LateLintPass};
 use rustc_session::declare_lint_pass;
 
 declare_clippy_lint! {
@@ -53,7 +53,7 @@ const BRACED_EXPR_MESSAGE: &str = "omit braces around single expression conditio
 
 impl<'tcx> LateLintPass<'tcx> for BlocksInConditions {
     fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
-        if expr.span.in_external_macro(cx.sess().source_map()) {
+        if expr.span.from_expansion() {
             return;
         }
 
@@ -83,7 +83,7 @@ impl<'tcx> LateLintPass<'tcx> for BlocksInConditions {
                     if let Some(ex) = &block.expr {
                         // don't dig into the expression here, just suggest that they remove
                         // the block
-                        if expr.span.from_expansion() || ex.span.from_expansion() {
+                        if ex.span.from_expansion() {
                             return;
                         }
 
@@ -114,7 +114,7 @@ impl<'tcx> LateLintPass<'tcx> for BlocksInConditions {
                     }
                 } else {
                     let span = block.expr.as_ref().map_or_else(|| block.stmts[0].span, |e| e.span);
-                    if span.from_expansion() || expr.span.from_expansion() || is_from_proc_macro(cx, cond) {
+                    if span.from_expansion() || is_from_proc_macro(cx, cond) {
                         return;
                     }
                     // move block higher

clippy_lints/src/casts/borrow_as_ptr.rs

@@ -24,6 +24,7 @@ pub(super) fn check<'tcx>(
         && !is_lint_allowed(cx, BORROW_AS_PTR, expr.hir_id)
         // Fix #9884
         && !is_expr_temporary_value(cx, e)
+        && !expr.span.in_external_macro(cx.tcx.sess.source_map())
         && !is_from_proc_macro(cx, expr)
     {
         let mut app = Applicability::MachineApplicable;

clippy_lints/src/casts/cast_ptr_alignment.rs

@@ -36,6 +36,7 @@ fn lint_cast_ptr_alignment<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'_>, cast_f
         // when casting from a ZST, we don't know enough to properly lint
         && !from_layout.is_zst()
         && !is_used_as_unaligned(cx, expr)
+        && !expr.span.in_external_macro(cx.tcx.sess.source_map())
     {
         span_lint(
             cx,

clippy_lints/src/casts/cast_slice_different_sizes.rs

@@ -25,7 +25,12 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'tcx>, msrv: Msrv)
     {
         let from_size = from_layout.size.bytes();
         let to_size = to_layout.size.bytes();
-        if from_size != to_size && from_size != 0 && to_size != 0 && msrv.meets(cx, msrvs::PTR_SLICE_RAW_PARTS) {
+        if from_size != to_size
+            && from_size != 0
+            && to_size != 0
+            && msrv.meets(cx, msrvs::PTR_SLICE_RAW_PARTS)
+            && !expr.span.in_external_macro(cx.tcx.sess.source_map())
+        {
             span_lint_and_then(
                 cx,
                 CAST_SLICE_DIFFERENT_SIZES,

clippy_lints/src/casts/cast_slice_from_raw_parts.rs

@@ -35,6 +35,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, cast_expr: &Expr<'_>,
         && let ctxt = expr.span.ctxt()
         && cast_expr.span.ctxt() == ctxt
         && msrv.meets(cx, msrvs::PTR_SLICE_RAW_PARTS)
+        && !expr.span.in_external_macro(cx.tcx.sess.source_map())
     {
         let func = match rpk {
             RawPartsKind::Immutable => "from_raw_parts",

clippy_lints/src/casts/mod.rs

@@ -889,11 +889,10 @@ impl Casts {
 
 impl<'tcx> LateLintPass<'tcx> for Casts {
     fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
-        if expr.span.in_external_macro(cx.sess().source_map()) {
-            return;
-        }
-
         if let ExprKind::Cast(cast_from_expr, cast_to_hir) = expr.kind {
+            if expr.span.in_external_macro(cx.sess().source_map()) {
+                return;
+            }
             if is_hir_ty_cfg_dependant(cx, cast_to_hir) {
                 return;
             }

clippy_lints/src/casts/ptr_cast_constness.rs

@@ -90,6 +90,7 @@ pub(super) fn check_null_ptr_cast_method(cx: &LateContext<'_>, expr: &Expr<'_>)
         && let mut app = Applicability::MachineApplicable
         && let sugg = snippet_with_applicability(cx, cast_from_expr.span, "_", &mut app)
         && let Some((_, after_lt)) = sugg.split_once("::<")
+        && !expr.span.in_external_macro(cx.tcx.sess.source_map())
     {
         span_lint_and_sugg(
             cx,

clippy_lints/src/default_numeric_fallback.rs

@@ -88,12 +88,12 @@ impl<'a, 'tcx> NumericFallbackVisitor<'a, 'tcx> {
 
     /// Check whether a passed literal has potential to cause fallback or not.
     fn check_lit(&self, lit: Lit, lit_ty: Ty<'tcx>, emit_hir_id: HirId) {
-        if !lit.span.in_external_macro(self.cx.sess().source_map())
-            && matches!(self.ty_bounds.last(), Some(ExplicitTyBound(false)))
+        if matches!(self.ty_bounds.last(), Some(ExplicitTyBound(false)))
             && matches!(
                 lit.node,
                 LitKind::Int(_, LitIntType::Unsuffixed) | LitKind::Float(_, LitFloatType::Unsuffixed)
             )
+            && !lit.span.in_external_macro(self.cx.sess().source_map())
         {
             let (suffix, is_float) = match lit_ty.kind() {
                 ty::Int(IntTy::I32) => ("i32", false),