fix(doc): replace *const i8 with *const c_char

[A4-Tacks]

changelog: none

On aarch64, methods::MANUAL_C_STR_LITERALS doc test run failed

[rustbot]

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

[CommanderStorm]

ok, sure. I don't quite understand why it fails, and how it failes, but seems fairly sensible...

Community review: LGTM

View changes since this review

[A4-Tacks]

On different platforms, c_char can be signed char or unsigned char

Both CStr::as_ptr and libc::puts use c_char, but this test case does not have it

fn puts(_: *const i8) {}

fn main() {
    puts(c"World".as_ptr())
       //^^^^^^^^^^^^^^^^^ expected `*const i8`, found `*const u8`
}

[DanielEScherzer]

community review: looks good to me

View changes since this review

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho for the project review.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 9 candidates
• 9 candidates expanded to 9 candidates
• Random selection from Jarcho, Manishearth, blyxyas, dswij, llogiq

[Jarcho]

Thank you.

@rustbot merge

View changes since this review