CaloReco: Require Calibs by Default

[Steepspace]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Require presence of hot maps, chi2, time calib, zs calib by default.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Motivation / context

CaloReco now requires key calibration inputs by default. This is a breaking change for workflows with missing calibrations.

Key changes

• CaloTowerCalib enables aborts for missing energy, time, and zero-suppression calibration.
• CaloTowerStatus enables aborts for missing hot-map and chi2 calibration.

Potential risk areas

• Reconstruction jobs without these calibrations can now abort.
• No IO format, thread-safety, or performance changes are indicated.
• Test results and review severity counts are unavailable.

Possible future improvements

• Add tests for missing-calibration behavior.
• Document required calibrations and opt-out configuration.
• Provide clear diagnostics for each missing calibration.

AI-generated summaries can contain mistakes. Verify the implementation and workflow impact before merging.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 80e179ce-6e03-4db1-bdfd-4b62dcdf5c99

📥 Commits

Reviewing files that changed from the base of the PR and between 75073c2 and 55ef423.

📒 Files selected for processing (2)

• offline/packages/CaloReco/CaloTowerCalib.h
• offline/packages/CaloReco/CaloTowerStatus.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The pull request changes five CaloReco abort-control defaults from false to true. The affected classes are CaloTowerCalib and CaloTowerStatus.

Changes

CaloReco abort defaults

Layer / File(s)	Summary
Enable abort defaults offline/packages/CaloReco/CaloTowerCalib.h, offline/packages/CaloReco/CaloTowerStatus.h	CaloTowerCalib now aborts by default when energy, time, or zero-suppression calibration is missing. CaloTowerStatus now aborts by default when the hot map or chi-squared data is missing.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 55ef4

The intentional breaking default change has no demonstrated correctness or compatibility defect, so it is mergeable after normal checks.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Steepspace]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sphenix-jenkins-ci]

Build & test report

Report for commit 55ef4234075ebe3dfcc29f67da4041c74d4ff802:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 49.8894 / 72, and combined p-Value = 0.978165
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 34.6977 / 72, and combined p-Value = 0.99994
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 89.0492 / 42, and combined p-Value = 3.12982e-05
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 15.0901 / 42, and combined p-Value = 0.999958
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = 1.79963e-11 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2_Fitting.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration
           

[Steepspace]

Superseded by sPHENIX-Collaboration/macros#1387