Public PHActsSiliconSeeding setters for cluster cuts - #4442
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesINTT cluster filtering
Sequence Diagram(s)sequenceDiagram
participant Configuration
participant PHActsSiliconSeeding
participant TrkrCluster
participant getSiliconSpacePoints
Configuration->>PHActsSiliconSeeding: Set INTT ADC and phi-size limits
TrkrCluster->>PHActsSiliconSeeding: Provide cluster data
PHActsSiliconSeeding->>PHActsSiliconSeeding: Apply passesInttClusterCuts
PHActsSiliconSeeding->>getSiliconSpacePoints: Process accepted cluster
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The new cuts remain disabled by default and are consistently applied when configured. No actionable merge risk remains. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: ee8712c2-c513-444c-bf75-e8dc5d4800e9
📒 Files selected for processing (2)
offline/packages/trackreco/PHActsSiliconSeeding.ccoffline/packages/trackreco/PHActsSiliconSeeding.h
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
Build & test reportReport for commit 6315aed8d5b82bfc51f645e122e49d571f8f772e:
Automatically generated by sPHENIX Jenkins continuous integration |
Build & test reportReport for commit de88f4255d56eb48424606ecbdc1cf92a039ad6d:
Automatically generated by sPHENIX Jenkins continuous integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
Adds public PHActsSiliconSeeding setters to configure a cluster minimum ADC and maximum phi-size cut. Both cuts default to disabled (-1).
(The large number of changes come from the clang-format that I accidentally triggered.)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Motivation / context
This change supports systematic studies of INTT cluster selection in
PHActsSiliconSeeding. Both cuts are disabled by default with a value of-1.Key changes
Potential risk areas
Possible future improvements
AI-generated summaries can contain mistakes. Contributors should verify the implementation and test results before merging.