refactor(data-grid): refactor const - #1129
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sadmann7
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors PartyKit seed-related constants into a dedicated party/constants.ts module and updates the multiplayer demo to import TRICKS from that new module, avoiding pulling seed-generation dependencies into client-side code.
Changes:
- Introduces
party/constants.tsexportingSTANCES,STYLES,STATUSES, andTRICKS. - Updates
party/seeds.tsto consume those constants from./constantsinstead of defining them inline. - Updates the multiplayer demo to import
TRICKSfrom@party/constants(instead of@party/seeds).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/data-grid-multiplayer/components/data-grid-multiplayer-demo.tsx | Switches the TRICKS import to the new constants module for client-safe consumption. |
| party/seeds.ts | Removes duplicated constant definitions and imports shared constants from ./constants. |
| party/constants.ts | New shared constants module that can be imported without bringing in seed-generation dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.