fix(data-grid): fix ranged pasting - #1137
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with data-grid paste handling, particularly ranged pasting behavior and parsing clipboard TSV content across different line-ending formats.
Changes:
- Normalize unquoted TSV parsing to handle Windows CRLF by stripping trailing
\rper line. - Improve paste behavior to support filling a selection when the clipboard contains a single cell value.
- Adjust
onDataUpdateto better handle updates that may involve rows not yet reflected inpropsRef.current.data, and update the generated registry snapshot.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/lib/data-grid.ts |
Normalizes TSV line parsing by stripping trailing carriage returns for CRLF clipboard content. |
src/hooks/use-data-grid.ts |
Updates paste/update logic to better cover ranged pasting scenarios (single-cell fill + row update range handling) and tweaks select paste empty handling. |
public/r/data-grid.json |
Updates the registry snapshot to reflect the latest use-data-grid and data-grid source contents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.